← Back to issue list

plugins: strip plugin properties in non-destructive way (CRAFT-394)

View original Github issue

Metadata

Project
craft-parts
Number
#101
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged a change to strip plugin properties non-destructively, preventing mutation of original parts data. Approved by one reviewer, passed CI, and modified five files.

Suggested action:

No scores available.

Issue body

Stripping plugin properties shouldn't change original parts data that has been supplied by the application using craft-parts. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a change to strip plugin properties non-destructively, preventing mutation of original parts data. Approved by one reviewer, passed CI, and modified five files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that strips plugin properties without modifying the original parts data supplied by applications using craft-parts, resolving CRAFT-394.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#117 plugins: fix plugin properties test (CRAFT-483) craft-parts merged Merged fix for CRAFT-483 correcting instance assignment to the plugin properties class variable in tests. Approved by two reviewers and passed CI checks.
73%
#71 plugins: check presence of required part properties (CRAFT-74) craft-parts merged Merged after two approvals and passing CI. Replaces manual verification of required plugin properties, such as source, with Pydantic validation. Updated nine files (+78/-25 lines) to enforce property requirements during plugin configuration.
71%