sources: verify deleted files in outdated check (CRAFT-440)
Metadata
Current evaluation
Merged #105 via 5d56713d (merge afef6cbb) to detect and remove source-deleted files/directories during outdated checks; behavior was later reverted by #132 in 5e5cb6c6.
Resolution: closed resolved
Reason: PR #105 was merged as afef6cbb, with change 5d56713d adding deleted-file and directory detection and cleanup. PR #132 later reverted that behavior in 5e5cb6c6 to preserve generated and override-pull files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
When verifying if a pulled source is outdated, also check for files
or directories that might have been deleted from the source directory.
If this is the case, also remove the files or directories from the
part source directory.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #105 via 5d56713d (merge afef6cbb) to detect and remove source-deleted files/directories during outdated checks; behavior was later reverted by #132 in 5e5cb6c6. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #105 via 5d56713d to detect and remove files and directories deleted from pulled sources during outdated checks. Later reverted by #132 via 5e5cb6c6. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in afef6cbb (implementation 5d56713d): outdated-source checks now detect deleted files and directories and remove them from the part source directory. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #105 (5d56713d), extending outdated-source verification to detect files or directories deleted upstream and remove them from the part source directory. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to outdated source verification that detects and removes deleted files or directories from the part source directory. Approved by two reviewers, passed CI, and modified three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates source outdated verification to detect and remove deleted files or directories from the part source directory. Resolves CRAFT-440. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-parts#132
(confidence 99%)
Merged revert #132 disabled deleted-source cleanup because it could remove build artifacts and override-pull files.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #132 sources: revert updating deleted files in outdated check (CRAFT-532) | craft-parts | merged | Merged #132 via 5e5cb6c6, disabling deleted-file synchronization to preserve build artifacts and override-pull files; deleted sources must be repulled. |