sources: revert updating deleted files in outdated check (CRAFT-532)
Metadata
Current evaluation
Merged to revert commit 5d56713, which incorrectly removed build artifacts and user-created files during source migration. Disables deleted file synchronization to preserve artifacts, replacing PR #129. Users must repull if local sources are deleted.
Suggested action: —
No scores available.
Issue body
Commit 5d56713 is the wrong solution for the problem as it removes build
artifacts (because LocalSource is reused to migrate from `part_src_dir`
to `part_build_dir`) and any files created by the user in override-pull.
Updating deleted files can be revisited later. We should disable deleted
file synchronization during the migration to preserve build artifacts,
and be sure that the pull update handler is aware of new files created
as a part of the pull step.
For now, if the user deletes local source files they need to repull.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to revert commit 5d56713, which incorrectly removed build artifacts and user-created files during source migration. Disables deleted file synchronization to preserve artifacts, replacing PR #129. Users must repull if local sources are deleted. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a revert of commit 5d56713 to resolve build artifact loss during directory migration. The change disables deleted file synchronization during migration, replacing PR #129. Local source deletions now require a manual repull. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #105 sources: verify deleted files in outdated check (CRAFT-440) | craft-parts | merged | Merged update to outdated source verification that detects and removes deleted files or directories from the part source directory. Approved by two reviewers, passed CI, and modified three files. |