sources: revert updating deleted files in outdated check (CRAFT-532)
Metadata
Current evaluation
Merged #132 via 5e5cb6c6, disabling deleted-file synchronization to preserve build artifacts and override-pull files; deleted sources must be repulled.
Resolution: closed resolved
Reason: PR #132 was merged as commit 5e5cb6c6 with merge commit 7d00e5f6. It reverted the faulty update that deleted build artifacts and files created during override-pull.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Commit 5d56713 is the wrong solution for the problem as it removes build
artifacts (because LocalSource is reused to migrate from `part_src_dir`
to `part_build_dir`) and any files created by the user in override-pull.
Updating deleted files can be revisited later. We should disable deleted
file synchronization during the migration to preserve build artifacts,
and be sure that the pull update handler is aware of new files created
as a part of the pull step.
For now, if the user deletes local source files they need to repull.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #132 via 5e5cb6c6, disabling deleted-file synchronization to preserve build artifacts and override-pull files; deleted sources must be repulled. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #132 via 5e5cb6c6, reverting deleted-file synchronization to preserve build artifacts and override-pull files; users must repull after deleting sources. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to revert commit 5d56713, which incorrectly removed build artifacts and user-created files during source migration. Disables deleted file synchronization to preserve artifacts, replacing PR #129. Users must repull if local sources are deleted. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a revert of commit 5d56713 to resolve build artifact loss during directory migration. The change disables deleted file synchronization during migration, replacing PR #129. Local source deletions now require a manual repull. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
craft-parts#129
(confidence 99%)
Its partial fix preserved build artifacts but could still delete files created during override-pull.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #105 sources: verify deleted files in outdated check (CRAFT-440) | craft-parts | merged | Merged #105 via 5d56713d (merge afef6cbb) to detect and remove source-deleted files/directories during outdated checks; behavior was later reverted by #132 in 5e5cb6c6. | |
| #129 sources: fix removed file updates (CRAFT-532) | craft-parts | closed | Closed unmerged; #132 superseded #129 by reverting commit 5d56713 in 5e5cb6c6, merged as 7d00e5f6, to avoid deleting build and override-pull artifacts. |