← Back to issue list

packaging: address linter issues in setup.py (CRAFT-461)

View original Github issue

Metadata

Project
craft-parts
Number
#110
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged. Resolved linter issues in setup.py to enable make lint and make tests. Approved by two reviewers, passed CI, and modified one file (+12/-6).

Suggested action: —

No scores available.

Issue body

Linters now run on setup.py. Address issues so that `make lint` and `make tests` execute as expected. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Resolved linter issues in setup.py to enable make lint and make tests. Approved by two reviewers, passed CI, and modified one file (+12/-6).
qwen3.6-35b-a3b-mtp-q6 — — Merged updates to setup.py that resolve linter warnings, enabling make lint and make tests to run successfully. Closes CRAFT-461.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#90 many: address new linter warnings (CRAFT-364) craft-parts merged Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines).
78%
#89 packaging: update setup script (CRAFT-281) craft-parts merged Merged update to setup.py packaging script to align with craft-providers patterns. Approved by two reviewers, the change modifies eight files (+190/-46 lines) and successfully integrates the updated build configuration.
76%
#130 packages: fix apt_pkg imports (CRAFT-534) craft-parts merged Merged fix for Pyright warnings about non-exported apt_pkg imports. Updated two files to use the top-level apt_pkg module. Approved by two reviewers with passing CI. The warning flagged a long-standing import pattern recently detected by updated static analysis.
71%
#606 packaging: use craft-store from PyPI (CRAFT-655) charmcraft merged Merged after approval. Replaced the craft-store git dependency with the PyPI release and updated other dependencies via freeze-requirements.txt. Changes modified four files.
70%