many: address new linter warnings (CRAFT-364)
Metadata
Current evaluation
Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines).
Suggested action: —
No scores available.
Issue body
Address linter warnings raised by new versions of mypy and pylint (or
silence some of them in tests).
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes addressing new linter warnings from updated mypy and pylint versions. Code was adjusted to satisfy stricter linting rules, with specific warnings silenced in test files. Resolves CRAFT-364. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #57 tests: update pylint and address new warnings | craft-parts | merged | Merged after two approvals and passing CI. Updated pylint to 2.8.2 and resolved newly introduced linting warnings in the test suite with minor code adjustments across a single file. | |
| #29 tests: address pylint issues | craft-parts | merged | Merged to address pylint warnings in test files. Approved by three reviewers and passed CI. The update modified three files, adding seven and removing four lines. | |
| #856 style: update mypy and fix linting issues | craft-application | merged | Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions. | |
| #110 packaging: address linter issues in setup.py (CRAFT-461) | craft-parts | merged | Merged. Resolved linter issues in setup.py to enable make lint and make tests. Approved by two reviewers, passed CI, and modified one file (+12/-6). | |
| #77 lint: fix linting issues with up-to-date linters | craft-store | merged | Merged a maintainer-submitted pull request resolving linting errors from updated linter versions. Approved by one reviewer, passed CI, and modified 11 files (+40/-24 lines). | |
| #350 linters: set disallow_untyped_defs in mypy | craft-parts | merged | Merged after approval and passing CI. Enables mypy disallow_untyped_defs, enforcing type annotations across 55 files in craft_parts. Author updated tests and addressed reviewer feedback prior to merge. | |
| #66 lint: update pylint configuration | craft-store | merged | Merged an update to the pylint configuration, removing 627 lines of outdated settings and adding 16 lines with no functional changes. Approved by a reviewer and passed all CI checks. | |
| #4815 linter updates | snapcraft | merged | Merged linter updates across 10 files, reducing 56 lines and adding 26. Approved by two reviewers with zero unresolved comments. | |
| #164 lint: compliance with pylint-2.12.2 (CRAFT-716) | craft-parts | merged | Merged to enforce pylint 2.12.2 compliance. Approved by two reviewers. One reviewer suggested disabling a default encoding warning instead of explicitly setting it. The branch was merged with 15 unresolved comments. | |
| #5374 docs: migrate library linting tips | snapcraft | merged | Merged documentation update migrating library linting tips to the linter warnings section. Approved by two reviewers, passed CI checks, and resolves CRAFT-4235. Changed three files with 39 additions and 2 deletions. |