← Back to issue list

many: address new linter warnings (CRAFT-364)

View original Github issue

Metadata

Project
craft-parts
Number
#90
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-parts#90 (commit 23f38957), resolving CRAFT-364 by fixing or suppressing new mypy and pylint warnings.

Resolution: closed resolved

Reason: PR #90 was approved and merged via merge commit 4493e93f. Its change commit 23f38957 updated code and test suppressions to address warnings from newer mypy and pylint versions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Address linter warnings raised by new versions of mypy and pylint (or silence some of them in tests). Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#90 (commit 23f38957), resolving CRAFT-364 by fixing or suppressing new mypy and pylint warnings.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#90, updating code and test suppressions to address mypy and pylint warnings from CRAFT-364; +32/-22 lines across 8 files.
qwen/qwen3.6-35b-a3b — — Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged changes addressing new linter warnings from updated mypy and pylint versions. Code was adjusted to satisfy stricter linting rules, with specific warnings silenced in test files. Resolves CRAFT-364.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#856 style: update mypy and fix linting issues craft-application merged Merged in canonical/craft-application#856 (177c2cc4), updating mypy and fixing linting issues; all listed CI checks passed.
71%
#1258 Improve typing and linting craft-parts closed Strict Pyright checks and typing fixes were merged in canonical/craft-parts#1294 at bb62329e, addressing suppressions and strict-mode requirements.
71%