refactor: split _check_for_stage_collisions_per_partition
Metadata
Current evaluation
Abandoned and closed without merging due to failing CI tests across multiple environments. The refactor split a collision-checking function to prepare for overlay conflict resolution but received no reviewer feedback.
Suggested action: —
No scores available.
Issue body
The function did both a) gather the files and permissions per part and b) check the sets of files for each part for conflicts. Split the first bit into a separate function, with no behavior changes, so that we can next include the overlay in conflict resolution.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Abandoned and closed without merging due to failing CI tests across multiple environments. The refactor split a collision-checking function to prepare for overlay conflict resolution but received no reviewer feedback. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed after refactoring to separate file gathering from conflict checking, preparing for overlay integration. No comments or requested changes. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1188 refactor: split _check_for_stage_collisions_per_partition | craft-parts | merged | Squash merged after approvals and passing CI. Refactors _check_for_stage_collisions_per_partition by separating file gathering from conflict checking, enabling future overlay conflict resolution without altering current behavior. | |
| #662 feat(executor): check for stage file collisions in each partition | craft-parts | merged | Merged. Adds stage file collision checks per partition to fix issue #633. Includes refactored unit tests and new integration tests. Approved by reviewers and passed CI. |