← Back to issue list

Check for staged file collisions in each partition

View original Github issue

Metadata

Project
craft-parts
Number
#633
Type
issue
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Fixed by PR #662 (merged as commit 4b28d649, CRAFT-2416): check_for_stage_collisions() now iterates over every partition and delegates to _check_for_stage_collisions_per_partition().

Resolution: closed resolved

Reason: PR #662 by maintainer mr-cal was merged as commit 4b28d649 ("feat(executor): check for stage file collisions in each partition"), adding per-partition staged-file collision detection in craft_parts/executor/collisions.py and explicitly closing #633.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done The [`check_for_stage_collisions()`](https://github.com/canonical/craft-parts/blob/5ad7be9c186f577d813e416330913497f868ee3b/craft_parts/executor/collisions.py#L30) function needs to check for file collisions in each partition. ### Why it needs to get done Currently, craft-parts is only checking for collisions in the default partition.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by PR #662 (merged as commit 4b28d649, CRAFT-2416): check_for_stage_collisions() now iterates over every partition and delegates to _check_for_stage_collisions_per_partition().
stealth/space-bunny-alpha — closed resolved Merged PR #662 (commit 4b28d649) added per-partition staged-file collision checks to check_for_stage_collisions(), fixing this issue.
qwen/qwen3.6-35b-a3b — — Extended check_for_stage_collisions() to verify file collisions across all partitions rather than just the default. Resolved and merged via pull request #662.
qwen/qwen3.6-35b-a3b — — Resolved via PR #662. The check_for_stage_collisions() function now validates file collisions across all partitions rather than only the default partition.
qwen/qwen3.6-35b-a3b — — check_for_stage_collisions() now validates file collisions across all partitions rather than only the default one. Resolved and closed by pull request #662.
qwen3.6-35b-a3b-mtp-q6 — — Updated check_for_stage_collisions() to verify staged file collisions across all partitions rather than just the default. Resolved and merged via pull request #662.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#662 (confidence 99%)

    Merged PR referenced in the closing comment; commit 4b28d649 adds the per-partition loop in check_for_stage_collisions().

  • Related To: canonical/craft-parts#1188 (confidence 70%)

    Later refactor (ef08d620) split _check_for_stage_collisions_per_partition() into its own function, building on this change.

Related issues

Issue Project State Summary Similarity
#662 feat(executor): check for stage file collisions in each partition craft-parts merged PR #662 by maintainer mr-cal merged as commit 4b28d649, adding check_for_stage_collisions() per-partition staged-file collision detection in craft_parts/executor/collisions.py; fixes #633 (CRAFT-2416). +526/-114 across 8 files.
84%
#1188 refactor: split _check_for_stage_collisions_per_partition craft-parts merged Squash-merged as ef08d620, splitting per-part file and permission collection from collision checks without behavior changes.
73%
#1186 refactor: split _check_for_stage_collisions_per_partition craft-parts closed Closed unmerged; the refactor was superseded by canonical/craft-parts#1188, squash-merged as ef08d620.
72%