Clean doesn't remove the overlay directory
Metadata
Current evaluation
Fixed in 2.20.1 by merged PR #1208 (bea8d2dc); PR #1223 merged the release branch into main (30ea3701), restoring overlay-directory cleanup.
Resolution: closed resolved
Reason: PR #1208 fixed executor overlay cleanup in 2.20.1. The fix was subsequently merged into main by PR #1223 at commit 30ea3701.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
https://github.com/canonical/craft-parts/pull/1164 introduced a change that is causing [this integration test](https://github.com/canonical/craft-application/blob/c5fdcf0521a7c026cace5883bd7590fc841536ed/tests/integration/services/test_lifecycle.py#L51) in craft-application to fail because the overlay directory isn't getting removed.
### Why it needs to get done
Craft-application integration tests are failing.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Fixed in 2.20.1 by merged PR #1208 (bea8d2dc); PR #1223 merged the release branch into main (30ea3701), restoring overlay-directory cleanup. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed in 2.20.1 by #1208 (bea8d2dc); PR #1223 merged the release branch into main (30ea3701), resolving the regression caused by #1164. | |
| stealth/space-bunny-alpha | — | closed resolved | Overlay cleanup was fixed in craft-parts 2.20.1; PR #1223 (commit 30ea3701) merged the release back into main, resolving the regression introduced by #1164. | |
| stealth/space-bunny-alpha | — | closed resolved | Overlay cleanup was fixed by #1208 (bea8d2dc), released in 2.20.1 and merged into main by #1223 (30ea3701). | |
| stealth/space-bunny-alpha | — | closed resolved | Overlay cleanup was fixed by merged PR #1208 (commit bea8d2dc), released in 2.20.1, then merged from 2.20.1 into main by #1223. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed in craft-parts 2.20.1; the release branch fix was later merged into main by commit 30ea3701 (#1223). | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed in version 2.20.1, resolving integration test failures caused by the clean command not removing the overlay directory. The fix was not merged back to main. | |
| qwen/qwen3.6-35b-a3b | — | — | The overlay directory cleanup bug was fixed in version 2.20.1, but the patch was not merged back to the main branch. The issue is now closed. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed in version 2.20.1, resolving craft-application integration test failures caused by the clean command not removing the overlay directory. The fix was not merged back to main. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | A change in PR #1164 caused the clean command to skip removing the overlay directory, failing craft-application integration tests. The bug was fixed in version 2.20.1, but the patch was not merged back to main. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-parts#1208
(confidence 100%)
Merged commit bea8d2dc cleans executor overlay directories.
-
Related To:
canonical/craft-parts#1223
(confidence 100%)
Merged commit 30ea3701 brought the 2.20.1 fix into main.
-
Caused By:
canonical/craft-parts#1164
(confidence 95%)
The issue identifies this change as the regression source.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1207 Overlay directory is not removed on a clean | craft-parts | closed | Fixed in merged PR #1208 (commit bea8d2dc), which removes executor overlay directories during cleanup. |