← Back to issue list

test: mark the slowest unit tests as slow

View original Github issue

Metadata

Project
craft-parts
Number
#1274
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit c7ecf029: added @pytest.mark.slow to the slowest unit tests (>2s each) in test_migration.py, test_part_handler.py, test_apt_cache.py, test_chisel.py and test_deb.py. Approved by 2 reviewers, all CI checks green.

Resolution: closed resolved

Reason: The PR itself was merged into the main branch as commit c7ecf029 ('test: mark the slowest unit tests as slow (#1274)'), adding pytest slow markers so those tests are excluded from the fast test suite run by 'pytest -m "not slow"' in common.mk. All CI jobs passed and review was approved with no unresolved comments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

These all take over 2 seconds each. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit c7ecf029: added @pytest.mark.slow to the slowest unit tests (>2s each) in test_migration.py, test_part_handler.py, test_apt_cache.py, test_chisel.py and test_deb.py. Approved by 2 reviewers, all CI checks green.
stealth/space-bunny-alpha — closed resolved Merged as c7ecf029 via #1274, marking tests taking over two seconds as slow. All CI checks passed after two approvals.
qwen/qwen3.6-35b-a3b — — Merged following two approvals and successful CI checks. The change marks unit tests exceeding two seconds as slow, adding six lines across four files to improve test execution tracking.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer lengau to mark unit tests exceeding two seconds of execution time as slow. The change updates test configuration to improve CI performance tracking and execution filtering.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#293 (confidence 80%)

    Earlier PR that registered the 'slow' mark with pytest, which these new markers rely on.

  • Related To: canonical/craft-parts#358 (confidence 75%)

    Earlier PR adding the 'make test-find-slow' target used to identify which tests exceed the cutoff time.

Related issues

Issue Project State Summary Similarity
#658 test(remote-build): mark slow remote-build unit tests as slow craft-application merged Merged PR #658 (commit 2b31b06e) added two @pytest.mark.slow annotations to slow remote-build unit tests, letting them be deselected in the default fast test run.
72%
#5277 test: mark all legacy tests as slow snapcraft merged Merged in #5277 via commit 85a8b7ccb, marking all legacy tests as slow so make test-fast excludes them.
70%