← Back to issue list

test: mark all legacy tests as slow

View original Github issue

Metadata

Project
snapcraft
Number
#5277
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #5277 via commit 85a8b7ccb, marking all legacy tests as slow so make test-fast excludes them.

Resolution: closed resolved

Reason: PR #5277 was merged as commit 85a8b7ccb. Its slow-test marker excludes the legacy suite from the make test-fast target.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- The legacy tests are rarely wanted and are, on average, much slower than any of the modern tests. This PR marks them all as slow tests for the purposes of `make test-fast`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #5277 via commit 85a8b7ccb, marking all legacy tests as slow so make test-fast excludes them.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#5277 (85a8b7ccb), marking all legacy tests as slow so make test-fast excludes them.
stealth/space-bunny-alpha — closed resolved Merged PR #5277 in commit 85a8b7ccb, marking all legacy tests as slow so make test-fast excludes them.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#5277 (85a8b7ccb), marking all legacy tests as slow so make test-fast excludes them.
stealth/space-bunny-alpha — closed resolved Merged PR marked all legacy tests as slow so `make test-fast` skips them, reducing the default fast-test set’s runtime.
qwen/qwen3.6-35b-a3b — — Merged. Marks legacy tests as slow to exclude them from make test-fast. Approved by two reviewers, passed CI, and modified one file with seven added lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes marking all legacy tests as slow to exclude them from make test-fast runs, as they are rarely used and significantly slower than modern tests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#270 test: mark use_old_releases integration test as slow craft-archives merged Merged PR #270, which marks test_use_old_releases as slow to exclude it from fast test runs, following up on #269.
76%
#1274 test: mark the slowest unit tests as slow craft-parts merged Merged as commit c7ecf029: added @pytest.mark.slow to the slowest unit tests (>2s each) in test_migration.py, test_part_handler.py, test_apt_cache.py, test_chisel.py and test_deb.py. Approved by 2 reviewers, all CI checks green.
70%