← Back to issue list

test: mark all legacy tests as slow

View original Github issue

Metadata

Project
snapcraft
Number
#5277
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged. Marks legacy tests as slow to exclude them from make test-fast. Approved by two reviewers, passed CI, and modified one file with seven added lines.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- The legacy tests are rarely wanted and are, on average, much slower than any of the modern tests. This PR marks them all as slow tests for the purposes of `make test-fast`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Marks legacy tests as slow to exclude them from make test-fast. Approved by two reviewers, passed CI, and modified one file with seven added lines.
qwen3.6-35b-a3b-mtp-q6 Merged changes marking all legacy tests as slow to exclude them from make test-fast runs, as they are rarely used and significantly slower than modern tests.
qwen3.6-35b-a3b-mtp-q6 Merged changes mark all legacy tests as slow, excluding them from make test-fast execution. This speeds up routine test runs by skipping rarely used, slower legacy suites.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1274 test: mark the slowest unit tests as slow craft-parts merged Merged following two approvals and successful CI checks. The change marks unit tests exceeding two seconds as slow, adding six lines across four files to improve test execution tracking.
79%
#358 feat: new makefile target to identify slow tests starbase merged Merged a Makefile target that identifies tests marked with @pytest.mark.slow. Approved by two reviewers, passed CI, and added seven lines to one file. The change streamlines slow test identification to support starbase adoption.
73%
#658 test(remote-build): mark slow remote-build unit tests as slow craft-application merged Merged after two approvals and passing CI checks. The update marks slow remote-build unit tests as slow, applying a minimal two-line change across one file to improve test execution tracking.
70%