← Back to issue list

Add integration tests for make plugin

View original Github issue

Metadata

Project
craft-parts
Number
#1334
Type
issue
State
closed
Author
bepri
Labels
Status: Triaged
Created
Updated
Closed

Current evaluation

Request for make-plugin integration tests was fulfilled by merged PR #1387 (commit 431bd9e2), adding tests/integration/plugins/test_make.py plus a test_make fixture project covering build/install and make-parameters forwarding. Issue closed as done.

Resolution: closed resolved

Reason: PR #1387 merged as commit 431bd9e2 'test: add integration tests for make plugin', adding the parametrized integration tests and the test_make fixture that the issue's TODO comment asked for. The issue was closed with that work landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done The make plugin needs some integration tests to validate its behavior. Turns out, we never had any... ### Why it needs to get done Spawned from this TODO comment: https://github.com/canonical/craft-parts/blob/a20b49d1b27ecd00ab74eb786d0f2403184adc97/tests/integration/plugins/test_make.py#L1

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Request for make-plugin integration tests was fulfilled by merged PR #1387 (commit 431bd9e2), adding tests/integration/plugins/test_make.py plus a test_make fixture project covering build/install and make-parameters forwarding. Issue closed as done.
stealth/space-bunny-alpha — closed resolved Added make-plugin integration coverage in merged PR #1387 (commit 431bd9e2), including build/install behavior and make-parameter forwarding.
qwen/qwen3.6-35b-a3b — — Abandoned. The request to add integration tests for the make plugin was closed without implementation after a Jira ticket was created, with no follow-up pull requests or code changes recorded.
qwen/qwen3.6-35b-a3b — — Closed without implementation. No pull requests or code changes were linked, indicating the make plugin integration test request was abandoned or deferred.
qwen/qwen3.6-35b-a3b — — Requesting integration tests for the make plugin was closed without implementation or discussion, remaining abandoned and unresolved.
qwen3.6-35b-a3b-mtp-q6 — — Closed without a linked resolution or pull request. The request to add integration tests for the make plugin appears abandoned or completed externally, with no further development activity recorded.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#1387 (confidence 95%)

    Merged PR whose commit 431bd9e2 added tests/integration/plugins/test_make.py and the test_make fixture directory, resolving the TODO tracked by this issue.

  • Related To: canonical/craft-parts#711 (confidence 40%)

    Earlier commit 3ebbb406 'feat(docs): make plugin reference (#711)' is the make plugin documentation work; plugin itself came from 6e25a220 'plugins: add make plugin'.

Related issues

Issue Project State Summary Similarity
#1387 test: add integration tests for make plugin craft-parts merged Copilot-authored PR merged as commit 431bd9e2, adding tests/integration/plugins/test_make.py with parametrized integration tests covering make plugin build/install and make-parameters forwarding, closing issue #1334.
87%
#33 plugins: add make plugin craft-parts merged Merged PR #33 as commit 9a9d7c5c, adding a Make plugin for make-based parts (implementation commit 6e25a220).
70%