← Back to issue list

plugins: add make plugin

View original Github issue

Metadata

Project
craft-parts
Number
#33
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system.

Suggested action:

No scores available.

Issue body

The make plugin is useful to build make-based parts. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system.
qwen3.6-35b-a3b-mtp-q6 Merged a pull request introducing a make plugin for building make-based parts. Authored by maintainer Claudio Matsuoka, the change was accepted and integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3032 plugins: introduce v2.MakePlugin with rebuilding snapcraft merged Merged introduction of v2.MakePlugin with rebuilding support and proper environment setup. Approved by one reviewer, the change updates 23 files (+379/-92 lines).
81%
#935 cmake plugin: utilize MakePlugin build logic within CMakePlugin snapcraft merged Merged. Refactors MakePlugin build logic into a reusable method, allowing CMakePlugin to leverage existing customization. Approved by two reviewers, modified four files (+51/-31 lines), and added tests for the optional env parameter.
76%
#3069 make v2 plugin: make use of make-parameters snapcraft merged Merged the make v2 plugin update to utilize make-parameters. The change adds 59 lines and removes 8 across five files, successfully integrating the feature into the codebase.
75%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548.
75%
#35 plugins: add autotools plugin craft-parts merged Merged the addition of an autotools plugin for handling ./configure scripts. Approved by two reviewers, the change adds 195 lines across four files, successfully integrating new build system support.
75%
#3081 make v2 plugin: also pass make-parameters to install snapcraft merged Merged updates to the make v2 plugin to pass make-parameters to the install step. The change modified two files with 12 additions and 8 deletions, passed CI checks, received reviewer approval, and was successfully integrated.
74%
#1076 autotools: extend Make plugin instead of repeating code snapcraft merged Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files.
74%
#3037 plugins: introduce v2.CMakePlugin snapcraft merged Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions.
74%
#180 plugins: add meson plugin craft-parts merged Merged to add a Meson plugin and correct out-of-source build logic. Approved by one reviewer, the change introduces 532 additions across seven files and resolves CRAFT-863.
74%
#22 plugins: add plugin and plugin properties base classes craft-parts merged Merged: introduces base classes for the plugin subsystem and plugin properties. Approved by three reviewers, passed CI checks, and added 227 lines across six files to define part source building with optional plugin-specific properties.
74%