← Back to issue list

plugins: add make plugin

View original Github issue

Metadata

Project
craft-parts
Number
#33
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #33 as commit 9a9d7c5c, adding a Make plugin for make-based parts (implementation commit 6e25a220).

Resolution: closed resolved

Reason: PR #33 was approved by two reviewers and merged into main as 9a9d7c5c. Implementation commit 6e25a220 added the Make plugin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The make plugin is useful to build make-based parts. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #33 as commit 9a9d7c5c, adding a Make plugin for make-based parts (implementation commit 6e25a220).
stealth/space-bunny-alpha — closed resolved Merged the Make plugin for building make-based parts in #33 via commit 6e25a220 (merge 9a9d7c5c).
stealth/space-bunny-alpha — closed resolved Merged the make plugin for building make-based parts (+237/-1 across five files) in commit 6e25a220, merged by 9a9d7c5c after approval by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #33, adding a Make-based parts build plugin; implemented in commit 6e25a220.
stealth/space-bunny-alpha — closed resolved Merged PR #33, adding a Make plugin for building make-based parts in commit 6e25a220 via merge 9a9d7c5c.
qwen/qwen3.6-35b-a3b — — Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system.
qwen3.6-35b-a3b-mtp-q6 — — Merged a pull request introducing a make plugin for building make-based parts. Authored by maintainer Claudio Matsuoka, the change was accepted and integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#463 plugins: qmake craft-parts merged Merged qmake plugin support in PR #463 as commit 641edb59; the plugin shipped in craft-parts 1.27.0.
77%
#35 plugins: add autotools plugin craft-parts merged Merged PR #35, adding an Autotools plugin for parts built through the ./configure script; implementation 54b124c8, merge commit 6140b8e6.
75%
#184 plugins: cmake craft-parts merged Merged the CMake plugin port into craft-parts via PR #184, merge commit 57744f7a, with implementation commit 9ceb1fc8.
74%
#1387 test: add integration tests for make plugin craft-parts merged Copilot-authored PR merged as commit 431bd9e2, adding tests/integration/plugins/test_make.py with parametrized integration tests covering make plugin build/install and make-parameters forwarding, closing issue #1334.
74%
#3032 plugins: introduce v2.MakePlugin with rebuilding snapcraft merged Merged #3032 as commit 6bdc0acb5, introducing v2.MakePlugin with rebuilding support and proper environment setup.
72%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c.
72%
#2363 {make,cmake,autotools} plugin: add support for bases snapcraft merged Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93.
72%
#22 plugins: add plugin and plugin properties base classes craft-parts merged Merged PR #22 via commit b7868ab6, adding plugin and plugin-properties base classes for part-source construction and optional part-spec properties.
72%
#711 feat(docs): make plugin reference craft-parts merged Merged PR #711 as commit 3ebbb406, adding a Make plugin reference across two documentation files; the docs include it in the craft-parts 1.31.0 release.
71%
#1500759 Add support for overriding the Makefile location in makefile part type snapcraft (launchpad) closed Custom Makefile paths were added to the Make plugin in merged PR #264 (commit ef982f26f), resolving upstream issue #22.
71%