← Back to issue list

overlay: add overlay package install (CRAFT-81)

View original Github issue

Metadata

Project
craft-parts
Number
#134
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit 041af872, adding chrooted overlay package installation on each declaring part's upper layer so maintainer scripts run and package databases stay correct.

Resolution: closed resolved

Reason: PR #134 was approved and merged as 041af872, with implementation commit 7d61a78e. It installs overlay packages in a chroot on the appropriate layer.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Overlay packages are installed on the layer corresponding to the declaring part. This layer is configured as the upper directory of the overlay stack. The installation runs on a chrooted environment so that maintainer scripts are executed and the installed packages database is updated correctly. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit 041af872, adding chrooted overlay package installation on each declaring part's upper layer so maintainer scripts run and package databases stay correct.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#134 via commit 041af872, adding chrooted overlay package installation for CRAFT-81.
qwen/qwen3.6-35b-a3b — — Merged. Adds overlay package installation by executing maintainer scripts in a chrooted environment to correctly update the package database. Approved by two reviewers, with clarifications added on pychroot usage and empty file safety.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#139 (confidence 95%)

    Follow-up PR merged as bcd40b3b, replacing pychroot with a non-magic chroot implementation.

Related issues

Issue Project State Summary Similarity
#127 overlay: add overlay manager mount operations (CRAFT-80) craft-parts merged Merged #127 via commit 95f19f73 (merge c984efb8), adding overlay-manager mount operations; package installation was deferred to a separate change.
79%
#297 overlay: only refresh overlay packages if necessary craft-parts merged Merged in canonical/craft-parts#297 as commit bb41fdc4, avoiding unnecessary overlay package-cache mount and refresh work for parts without overlay packages.
77%
#113 overlay: add overlay support to parts (CRAFT-470) craft-parts merged Merged #113 via commit 2d90e608, adding overlay work-directory definitions, overlay subdirectory properties, and detection of overlay parameters and visibility for CRAFT-470.
77%
#137 many: add overlay step (CRAFT-84) craft-parts merged Merged craft-parts#137 as commit 1a813210, adding the overlay lifecycle step and subsystem support for package installation and filesystem mutations.
77%
#111 overlay: add overlayfs helpers (CRAFT-462) craft-parts merged Merged PR #111 via commit 7424a039, adding OverlayFS mount/unmount helpers and detection for special files and directories used in filesystem layering.
76%
#1472 feat: add override-overlay craft-parts merged Merged #1472 (43dc8484), adding override-overlay scriptlets that run during the overlay step in a chroot, with validation and tests.
76%
#147 executor: update overlay package list (CRAFT-581) craft-parts merged Merged #147 updates overlay package lists before lifecycle execution when overlays are enabled; implementation landed in 16fd4159 and merge 2a53bd01.
75%
#1415 feat: add override-overlay craft-parts merged Merged override-overlay support via #1472 (43dc8484), adding chrooted scriptlets, validation, mounts, hashing, and tests; docs followed in #1473 for 2.30.0.
73%
#1567 feat(overlay): plugins can define overlay commands craft-parts merged Merged as commit 73d6a988, enabling plugin-defined overlay-chroot commands that users can replace or wrap via override-overlay.
72%
#135 executor: add overlay step handling (CRAFT-86) craft-parts merged Merged PR #135 via b7527d5b, adding overlay-step execution handling that mounts the overlay stack during builds.
72%