← Back to issue list

overlay: only refresh overlay packages if necessary

View original Github issue

Metadata

Project
craft-parts
Number
#297
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-parts#297 as commit bb41fdc4, avoiding unnecessary overlay package-cache mount and refresh work for parts without overlay packages.

Resolution: closed resolved

Reason: PR #297 was approved and merged into the main project as commit bb41fdc4. It now refreshes overlay package caches only when overlay-packages are defined.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Only mount & refresh the overlay package cache if the part has overlay-packages; otherwise we're doing extra expensive work needlessly. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#297 as commit bb41fdc4, avoiding unnecessary overlay package-cache mount and refresh work for parts without overlay packages.
stealth/space-bunny-alpha — closed resolved Merged #297 as commit bb41fdc4, skipping overlay package-cache mounting and refresh work for parts without overlay-packages.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#297 (commit bb41fdc4), avoiding unnecessary overlay package-cache mount and refresh work for parts without overlay-packages.
qwen/qwen3.6-35b-a3b — — Merged an optimization that skips mounting and refreshing the overlay package cache unless a part uses overlay-packages, avoiding unnecessary expensive operations. Approved, passed CI, and changed three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged an optimization that restricts overlay package cache mounting and refreshing to parts using overlay-packages, eliminating unnecessary computational overhead.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#134 overlay: add overlay package install (CRAFT-81) craft-parts merged Merged in commit 041af872, adding chrooted overlay package installation on each declaring part's upper layer so maintainer scripts run and package databases stay correct.
77%
#127 overlay: add overlay manager mount operations (CRAFT-80) craft-parts merged Merged #127 via commit 95f19f73 (merge c984efb8), adding overlay-manager mount operations; package installation was deferred to a separate change.
75%
#147 executor: update overlay package list (CRAFT-581) craft-parts merged Merged #147 updates overlay package lists before lifecycle execution when overlays are enabled; implementation landed in 16fd4159 and merge 2a53bd01.
73%
#113 overlay: add overlay support to parts (CRAFT-470) craft-parts merged Merged #113 via commit 2d90e608, adding overlay work-directory definitions, overlay subdirectory properties, and detection of overlay parameters and visibility for CRAFT-470.
73%
#4948 docs: exclude overlay step, bump craft-parts to 1.34.0 snapcraft merged Merged in canonical/snapcraft#4948, fixing the docs build by excluding overlay-step docs and bumping craft-parts to 1.34.0 (f57f7e0c0, de13316cb).
72%
#299 feat: enable override-overlay imagecraft merged Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support.
72%
#1228 Reorder parts to prioritize organize to overlay craft-parts closed Prioritized parts that organize overlays so installing overlay-package parts can use the prepared base; merged in canonical/craft-parts#1261 (55d01a3f).
71%
#367 features: introduce craft-parts features craft-parts merged Merged PR #367 via commit 16a81f95, introducing configurable craft-parts features and an overlay toggle that suppresses overlay action generation when disabled.
70%