feature(pro_sources): craftctl chroot cmd
Metadata
Current evaluation
Adds a `craftctl chroot` subcommand letting overlay-script modify the overlay from inside the chroot (Rockcraft pro_sources). Approved by 1 reviewer, but 4 unresolved review comments and test-common CI jobs failing; no activity for ~359 days.
Suggested action: needs review
Reason: Review status is 'approved (1 reviewers)' and the change is small (+69/-3, 4 files), so the feature itself was accepted in principle; however there are 4 unresolved review comments and 'test-common / Slow tests' fail on every listed platform plus 'test-common / Minimum dependencies (all tests)', so it cannot land as-is. The only recent comment is the author asking for review (2025-10-03) with no maintainer response since, so it needs a maintainer to weigh in on the open comments and the core CI failures rather than being closed. Confidence is limited because the diff body and review-comment text were not retrievable, so I could not judge whether the test-common failures are pre-existing/flaky or caused by this change.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
33
Quick Win:
7
Complexity:
32
Confidence:
58
Actionability:
30
|
needs review | Adds a `craftctl chroot` subcommand letting overlay-script modify the overlay from inside the chroot (Rockcraft pro_sources). Approved by 1 reviewer, but 4 unresolved review comments and test-common CI jobs failing; no activity for ~359 days. | |
| qwen/qwen3.6-35b-a3b |
Impact:
25
Quick Win:
2
Complexity:
35
Confidence:
75
Actionability:
15
|
close stale | Adds a craftctl chroot subcommand for Rockcraft's pro_sources feature. Open 353 days ago with 1 approval, 4 unresolved review comments, and failing CI tests. No activity for 349 days. | |
| qwen/qwen3.8-27b |
Impact:
45
Quick Win:
20
Staleness:
75
Complexity:
55
Confidence:
65
|
needs review | Adds a craftctl chroot subcommand to modify overlays during overlay-script for Rockcraft's pro_sources feature. Approved by 1 reviewer but has 4 unresolved comments, failing CI, and ~9.5 months of inactivity. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
20
Confidence:
75
|
close stale | Adds a craftctl chroot subcommand to modify overlays during overlay-script. PR has one approval but 4 unresolved comments, failing CI, and ~9.5 months of inactivity. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
40
Confidence:
75
|
close stale | Adds a chroot subcommand to craftctl to modify overlays during overlay-script execution. Currently inactive for over 9 months with no maintainer feedback or CI status updates. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#1567
(confidence 45%)
Commit 73d6a988 'feat(overlay): plugins can define overlay commands' landed a plugin-side mechanism for running commands in the overlay chroot, overlapping the same problem area but not implementing `craftctl chroot`; ctl.py at HEAD still has no chroot command, so this PR is not superseded.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #920 feat: add "craftctl chroot" command | craft-parts | open | Adds a 'craftctl chroot' subcommand (3 files, +114/-2). External contributor PR from ~2 years ago: no CI checks, no reviewers, only comment 'this looks very useful'; same feature re-proposed in craft-parts#1350. | |
| #1480 chore: cleanup on pro-sources code | craft-parts | merged | PR #1480 merged after approval, removing the craftctl chroot command because override-overlay now provides a cleaner way to update pro-source base-overlay packages. |