← Back to issue list

feature(pro_sources): craftctl chroot cmd

View original Github issue

Metadata

Project
craft-parts
Number
#1350
Type
pull request
State
open
Author
clay-lake
Labels
Created
Updated
Closed

Current evaluation

Adds a craftctl chroot subcommand to modify overlays during overlay-script for Rockcraft's pro_sources feature. Approved by 1 reviewer but has 4 unresolved comments, failing CI, and ~9.5 months of inactivity.

Suggested action: needs review

Reason: The PR has 4 unresolved review comments and failing CI (test-common slow tests and minimum dependencies), and the author requested a review on 2025-10-03 with no subsequent activity. The feature is still relevant to the pro_sources workstream, but the unresolved comments and CI failures need to be addressed before it can be merged.

Impact: 45 Quick Win: 20.25 Staleness: 75 Complexity: 55 Confidence: 65

Issue body

This PR is part of Rockcraft's `pro_sources` feature set and includes the following features: - A `chroot` sub command for `craftctl` to enable modification to the overlay during the `overlay-script`

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 45
Quick Win: 20.25
Staleness: 75
Complexity: 55
Confidence: 65
needs review Adds a craftctl chroot subcommand to modify overlays during overlay-script for Rockcraft's pro_sources feature. Approved by 1 reviewer but has 4 unresolved comments, failing CI, and ~9.5 months of inactivity.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 20
Confidence: 75
close stale Adds a craftctl chroot subcommand to modify overlays during overlay-script. PR has one approval but 4 unresolved comments, failing CI, and ~9.5 months of inactivity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 40
Confidence: 75
close stale Adds a chroot subcommand to craftctl to modify overlays during overlay-script execution. Currently inactive for over 9 months with no maintainer feedback or CI status updates.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 45
Confidence: 65
needs review Introduces a chroot subcommand to craftctl for Rockcraft's pro_sources feature, allowing overlay modification during overlay-script. Open for over eight months and awaiting reviewer feedback.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#1567 (confidence 70%)

    PR #1567 (feat(overlay): plugins can define overlay commands) introduced the get_overlay_chroot_commands mechanism that this PR's chroot subcommand builds upon.

Related issues

Issue Project State Summary Similarity
#920 feat: add "craftctl chroot" command craft-parts open Adds a craftctl chroot command to run commands inside the part's chroot. Small diff (+114/-2, 3 files). Pending review with 0 reviewers; a maintainer called it useful, but no activity for ~20 months and the overlay chroot code has since been reworked.
78%
#1351 feature(pro_sources): mount package sources craft-parts open Adds mount_package_sources for Rockcraft pro_sources and refactors the Mount class to support bind/rbind and ramFS clone mounts. Pending review with 0 reviewers, 332 days old, and broad CI failures across many architectures.
74%