chore: cleanup on pro-sources code
Metadata
Current evaluation
PR #1480 merged after approval, removing the craftctl chroot command because override-overlay now provides a cleaner way to update pro-source base-overlay packages.
Resolution: closed resolved
Reason: PR #1480 is marked merged, approved by two reviewers, and has no failing or pending CI checks. It removes the temporary craftctl chroot command in favor of override-overlay for pro-source base-overlay updates.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The notable change here is the removal of the 'chroot' craftctl command. This new command was meant to be used by Rockcraft to update the packages in the base overlay layer when using pro sources, like this:
```yaml
parts:
apt-upgrade:
plugin: nil
overlay-script: |
craftctl chroot bash -c "apt-get update && apt-get -y upgrade"
```
... however, now with override-overlay we can do this much more cleanly:
```yaml
parts:
apt-upgrade:
plugin: nil
override-overlay: |
apt-get update
apt-get -y upgrade
```
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1480 merged after approval, removing the craftctl chroot command because override-overlay now provides a cleaner way to update pro-source base-overlay packages. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1480, removing the craftctl chroot command; #1472 and #1473 replaced that workflow with override-overlay. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged cleanup removed the craftctl chroot command now that override-overlay provides the pro-sources workflow (#1472, documented by #1473). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged cleanup of pro-sources code. Removed the craftctl chroot command in favor of the cleaner override-overlay directive for package updates. Approved by two reviewers with all CI checks passing. Squash merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Squash merged a cleanup removing the chroot craftctl command. The override-overlay directive now cleanly updates packages in the base overlay layer for pro sources, rendering the old command obsolete. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1050 chore(merge): feature/pro-sources into main | craft-application | merged | Pro sources support was merged into main by PR #1050 (commit 8c1a7aeb), resolving CRAFT-5016. | |
| #582 chore: merge main with pro sources | craft-application | merged | Merged main into feature/pro-sources via PR #582 (commit 559ec1e5), resynchronizing the long-lived branch after two approvals. | |
| #1350 feature(pro_sources): craftctl chroot cmd | craft-parts | open | Adds a `craftctl chroot` subcommand letting overlay-script modify the overlay from inside the chroot (Rockcraft pro_sources). Approved by 1 reviewer, but 4 unresolved review comments and test-common CI jobs failing; no activity for ~359 days. | |
| #918 chore(merge): feature/pro-sources into main | craft-providers | merged | Merged feature/pro-sources into main via #918 (commit b56ff14), completing CRAFT-5012 with all CI checks passing and 1,594 additions across 9 files. | |
| #1459 chore(merge): main into feature/override_overlay | craft-parts | merged | Merged PR #1459 (smethnani) synced main into feature/override_overlay, 2 approvals and all CI green; the feature it updates landed via #1472 (43dc8484) plus docs #1473 (1b2b7d5a), released in 2.30.0. | |
| #1184 chore(merge): feature/pro-sources into main | rockcraft | merged | Squash-merged feature/pro-sources into main as commit 1987d98b, changing 36 files; all reported CI checks passed and the PR received two approvals. |