← Back to issue list

feature(pro_sources): mount package sources

View original Github issue

Metadata

Project
craft-parts
Number
#1351
Type
pull request
State
open
Author
clay-lake
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds mount_package_sources for Rockcraft pro_sources and refactors the Mount class to support bind/rbind and ramFS clone mounts. Pending review with 0 reviewers, 332 days old, and broad CI failures across many architectures.

Suggested action: needs review

Reason: The PR is 332 days old with no maintainer interaction and widespread CI failures, but the author requested help from @upils on 2025-10-03 and the feature (mounting apt sources into overlays) is still relevant to Rockcraft pro_sources. The Mount class refactor and new mount types are non-trivial, so a maintainer should review whether this approach is still wanted before merging or closing.

Impact: 55 Quick Win: 16.5 Staleness: 75 Complexity: 70 Confidence: 65

Issue body

This PR is part of Rockcraft's `pro_sources` feature set and includes the following features: - Additional mountpoints to enable the `overlay` to access the apt sources from the build-env. See `mount_package_sources` - Refactor of the `Mount` class to support different kids of mounts (bind, rbind, etc) as well as a special class of mount of clone a specified directory into a ramFS.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 55
Quick Win: 16.5
Staleness: 75
Complexity: 70
Confidence: 65
needs review Adds mount_package_sources for Rockcraft pro_sources and refactors the Mount class to support bind/rbind and ramFS clone mounts. Pending review with 0 reviewers, 332 days old, and broad CI failures across many architectures.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 55
Confidence: 75
close stale Introduces apt source mountpoints and refactors the Mount class to support bind/rbind mounts and ramFS cloning. Currently pending review, inactive for 291 days, and shows multiple failing CI tests.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 60
Confidence: 75
close stale Adds mountpoints for overlay apt source access and refactors the Mount class to support bind/rbind/ramFS mounts. PR has been inactive for 278 days with no maintainer feedback or follow-up on author's merge plans.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 40
Confidence: 70
needs review Enables overlay apt source access via new mountpoints and refactors the Mount class for bind, rbind, and ramFS mounts. Stale for 258 days, awaiting maintainer review to merge pending bugfix changes.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#1483 (confidence 70%)

    Commit bedb4c0f 'feat: allow copying apt sources from host to overlay' addresses a related concern about apt sources in overlays, which this PR's mount_package_sources feature also targets.

Related issues

Issue Project State Summary Similarity
#1350 feature(pro_sources): craftctl chroot cmd craft-parts open Adds a craftctl chroot subcommand to modify overlays during overlay-script for Rockcraft's pro_sources feature. Approved by 1 reviewer but has 4 unresolved comments, failing CI, and ~9.5 months of inactivity.
74%