← Back to issue list

chore: make the starcraft-reviewers team own the changelog

View original Github issue

Metadata

Project
craft-parts
Number
#1361
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR to move docs/reference/changelog.rst ownership to starcraft-reviewers was closed unmerged as superseded by #1371 (also closed unmerged); the change landed via merged #1372 (commit 3d369498).

Resolution: closed superseded

Reason: The closing comment from @lengau states "Superseded by #1371", which was itself closed unmerged due to an accidental upstream branch; the CODEOWNERS change was ultimately merged in #1372 as commit 3d369498, and .github/CODEOWNERS now lists /docs/reference/changelog.rst under @canonical/starcraft-reviewers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Having the authors own the changelog is a heavy burden for them in our libraries that's minimally useful. Per @medubelko, from now on, TA reviews for the changelog are opt-in when we decide we need their input. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR to move docs/reference/changelog.rst ownership to starcraft-reviewers was closed unmerged as superseded by #1371 (also closed unmerged); the change landed via merged #1372 (commit 3d369498).
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by #1371; changelog ownership was later updated in merged #1372 (commit 3d369498).
qwen/qwen3.6-35b-a3b — — Transferring changelog ownership to the starcraft-reviewers team was approved and passed CI, but the pull request was closed and superseded by PR #1371.
qwen3.6-35b-a3b-mtp-q6 — — Changelog ownership was transferred to the starcraft-reviewers team to reduce author burden. The request was closed and superseded by #1371.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#1371 (confidence 97%)

    Directly cited in the closing comment as the superseding PR; closed unmerged after an accidental upstream branch

  • Superseded By: canonical/craft-parts#1372 (confidence 95%)

    Merged commit 3d369498 that actually applied the base/docs ownership update in .github/CODEOWNERS

  • Related To: canonical/craft-parts#1461 (confidence 70%)

    Later commit f8ce2833 'chore(codeowners): remove authors from changelog reviews' further refined the same ownership policy

Related issues

Issue Project State Summary Similarity
#179 chore: remove authors from changelog codeowners craft-platforms merged Merged PR #179 via commit 4605b38, moving general docs ownership to @canonical/starcraft-authors and assigning the changelog to @canonical/starcraft-reviewers.
81%
#937 chore: update CODEOWNERS craft-application merged Merged chore PR #937 (commit 3d31a9fa) updating .github/CODEOWNERS: changelog.rst ownership moved to @canonical/starcraft-reviewers, other docs to starcraft-authors, and CODEOWNERS itself to starcraft-maintainers.
77%
#177 chore: update codeowners owner craft-platforms merged Merged PR craft-platforms#177 (1 line changed in .github/CODEOWNERS): docs/ ownership added to @canonical/starcraft-authors, changelog to starcraft-reviewers; now present in the repo at main.
76%
#2353 docs: update `CONTRIBUTING.md` charmcraft merged Docs-only PR #2353 merged as commit 62abb2f4, replacing CONTRIBUTING.md with shared Starcraft guidance (+257/-58 across 2 files) and dropping a misplaced README link; approved by 2 reviewers.
72%
#995 chore: update codeowners rockcraft merged Merged as commit 7157c17c, adding starcraft-authors to CODEOWNERS and assigning @steinbro as the group owner.
72%
#2 chore: brand with Debcraft debcraft merged PR #2 by sergiusens merged: renamed Starcraft to Debcraft across 20 files (+166/-339) and added a minimal README.md; approved by 2 reviewers with all CI checks green.
71%
#1356 chore: update codeowners craft-parts merged Merged PR #1356 (commit 91f02a35) updated .github/CODEOWNERS: added the starcraft-authors group and set @steinbro as the CODEOWNERS owner (+2/-2).
71%
#2 many: rename starcraft to craft-archives craft-archives merged Merged PR #2, renaming the project from starcraft to craft-archives across seven files (+26/-60); maintainer review approved.
70%