← Back to issue list

fix(deps): update urllib3 to 2.5.1 to address security vulnerabilities

View original Github issue

Metadata

Project
craft-parts
Number
#1408
Type
pull request
State
closed
Author
Copilot
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; the urllib3 security update was superseded by merged PR #1411 (commit 044ea761), which upgraded uv.lock from urllib3 2.5.0 to 2.6.1.

Resolution: closed superseded

Reason: PR #1408 was closed without merging after PR #1411 landed the fix. Commit 044ea761 updates urllib3 in uv.lock from 2.5.0 to 2.6.1 to address the cited security advisories.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- ## Description The OSV-scanner in the security scan workflow detected critical vulnerabilities (GHSA-2xpw-w6gg-jr37 and GHSA-gm62-xv2j-4w53) in urllib3 2.5.0. ## Changes - Created `requirements/uv-requirements.--all-extras.txt` with all 140 dependencies from `uv.lock` - Updated urllib3 from 2.5.0 to 2.5.1 to address the CVEs The requirements file provides a known-good dependency snapshot for CI security scanning, ensuring urllib3 uses the patched version. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `astral.sh` > - Triggering command: `/usr/bin/curl curl -LsSf REDACTED` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/canonical/craft-parts/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > The job 'Security scan' failed in the GitHub Actions workflow due to critical vulnerabilities detected in the urllib3 dependency (version 2.5.0) as listed in requirements/uv-requirements.--all-extras.txt. The osv-scanner reported vulnerabilities GHSA-2xpw-w6gg-jr37 and GHSA-gm62-xv2j-4w53 for urllib3 2.5.0. > > To fix: > - Locate urllib3 in requirements/uv-requirements.--all-extras.txt. > - Update the version specification to a patched release, e.g., urllib3>=2.5.1, to address recent CVEs. > - Confirm the updated version is compatible with the project and rerun the workflow to verify the fix. > > References from job log: > - Vulnerability: https://osv.dev/GHSA-2xpw-w6gg-jr37 > - Vulnerability: https://osv.dev/GHSA-gm62-xv2j-4w53 > - Failing workflow: https://github.com/canonical/craft-parts/blob/07920c7e1715dcbe1050313093b493ee1acd3863/.github/workflows/policy.yaml > - Job log excerpt: ![image1](image1) > > Directly edit requirements/uv-requirements.--all-extras.txt as described above. </details> <!-- START COPILOT CODING AGENT SUFFIX --> *This pull request was created as a result of the following prompt from Copilot chat.* > The job 'Security scan' failed in the GitHub Actions workflow due to critical vulnerabilities detected in the urllib3 dependency (version 2.5.0) as listed in requirements/uv-requirements.--all-extras.txt. The osv-scanner reported vulnerabilities GHSA-2xpw-w6gg-jr37 and GHSA-gm62-xv2j-4w53 for urllib3 2.5.0. > > To fix: > - Locate urllib3 in requirements/uv-requirements.--all-extras.txt. > - Update the version specification to a patched release, e.g., urllib3>=2.5.1, to address recent CVEs. > - Confirm the updated version is compatible with the project and rerun the workflow to verify the fix. > > References from job log: > - Vulnerability: https://osv.dev/GHSA-2xpw-w6gg-jr37 > - Vulnerability: https://osv.dev/GHSA-gm62-xv2j-4w53 > - Failing workflow: https://github.com/canonical/craft-parts/blob/07920c7e1715dcbe1050313093b493ee1acd3863/.github/workflows/policy.yaml > - Job log excerpt: ![image1](image1) > > Directly edit requirements/uv-requirements.--all-extras.txt as described above. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; the urllib3 security update was superseded by merged PR #1411 (commit 044ea761), which upgraded uv.lock from urllib3 2.5.0 to 2.6.1.
stealth/space-bunny-alpha — closed superseded Closed unmerged. Copilot's PR adding requirements/uv-requirements.--all-extras.txt and bumping urllib3 to 2.5.1 was dropped; the actual fix landed via merged PR #1411 (commit 044ea761), which updated uv.lock to urllib3 2.6.1.
stealth/space-bunny-alpha — closed superseded Closed unmerged; the urllib3 security fix landed through PR #1411, updating uv.lock to 2.6.1 in commit 044ea761.
qwen/qwen3.6-35b-a3b — — Closed without merge. Updated urllib3 to 2.5.1 to resolve critical security vulnerabilities and added a requirements file for CI scanning. No reviews or CI checks were performed before closure.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The automated urllib3 update to 2.5.1 addressing CVEs was not integrated and appears abandoned.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#1411 (confidence 99%)

    Merged PR #1411 implemented the security fix more directly by updating uv.lock to urllib3 2.6.1.

Related issues

Issue Project State Summary Similarity
#5963 build(deps): bump urllib3 from 2.6.1 to 2.6.3 snapcraft closed Closed unmerged as a duplicate of merged PR #5930, which updated urllib3 to 2.6.3 in commit a473ada2c.
86%
#1130 build(deps): update dependency urllib3 to v2.5.0 [security] (main) craft-parts closed Renovate's urllib3 2.3.0->2.5.0 PR was closed unmerged as a duplicate of merged PR #1135 (commit 74e21521), which bumped urllib3 in pyproject.toml and uv.lock.
86%
#1133 build(deps): update dependency urllib3 to v2.5.0 [security] (hotfix/2.7) - autoclosed craft-parts closed Renovate PR #1133 was autoclosed without merge; the same urllib3 2.5.0 update was merged in #1135 as commit 74e21521.
85%
#5565 build(deps): update dependency urllib3 to v2 [security] (hotfix/8.9) snapcraft closed PR #5565 was closed unmerged: a maintainer said its urllib3 dependency file was unused. The obsolete docs requirements file was later removed by merged PR #5598 (f42ae1ee4).
85%
#5564 build(deps): update dependency urllib3 to v2 [security] (hotfix/7.5) snapcraft closed Renovate's urllib3 1.26.19->2.5.0 security bump for hotfix/7.5 was closed unmerged after medubelko noted it was "Not used"; the underlying docs/requirements.txt was later deleted in merged PR #5598 (f42ae1ee4).
84%
#5563 build(deps): update dependency urllib3 to v2 [security] (main) snapcraft closed Closed unmerged because the targeted dependency file was unused; merged PR #5598 (f42ae1ee4) deleted it, removing the need for urllib3 v2.
84%
#220 build(deps): update urllib3 to 2.8.0 craft-grammar merged Merged PR #220 updating urllib3 from 2.7.0 to 2.8.0 to address three OSV security vulnerabilities (PYSEC-2026-4175/4176/4177).
84%
#5596 build(deps): update dependency urllib3 to v2 [security] (hotfix/8.10) snapcraft closed Closed unmerged: the unused Sphinx requirements file made no update necessary; merged PR #5598 (f42ae1ee4) deleted it instead of upgrading urllib3.
84%
#4125 deps: update dependencies, freezing urllib3 < 2.0 snapcraft closed Closed unmerged as unnecessary after dependencies were refreshed by merged PR #4129 (commit fc9f9ae44).
84%
#108 build(deps): bump urllib3 from 2.5.0 to 2.6.3 starflow merged Merged PR #108 in commit 53cb793, upgrading urllib3 from 2.5.0 to 2.6.3 with decompression-bomb and DoS security fixes.
83%