fix: Update urllib3 to 2.6.1 to resolve security vulnerabilities
Metadata
Current evaluation
Copilot's PR merged as commit 044ea761, bumping urllib3 2.5.0 -> 2.6.1 in uv.lock to clear GHSA-2xpw-w6gg-jr37 and GHSA-gm62-xv2j-4w53; OSV/Trivy scans passed.
Resolution: closed resolved
Reason: PR #1411 was merged into main as commit 044ea761, which appears in the uv.lock history; the 3-line uv.lock change updated urllib3 to 2.6.1 and the Security scan (OSV-scanner, Trivy) checks all passed. A later routine bump landed in 1b60eff6 (#1430).
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
## Description
Security scans failing on urllib3 2.5.0 due to GHSA-2xpw-w6gg-jr37 and GHSA-gm62-xv2j-4w53 (both severity 8.9).
## Changes
- **uv.lock**: Updated urllib3 from 2.5.0 to 2.6.1 with corresponding package hashes
urllib3 2.6.1 resolves both advisories. No application code changes required.
The starflow CI workflow automatically generates requirements files from uv.lock during security scans, so no manual requirements file is needed in the repository.
<!-- START COPILOT ORIGINAL PROMPT -->
<details>
<summary>Original prompt</summary>
> ## Problem Statement: Security Job Failure
> The security scan in the Check policy workflow is failing due to high-severity vulnerabilities in the `urllib3` package (v2.5.0), as seen in the logs:
> > | https://osv.dev/GHSA-2xpw-w6gg-jr37 | 8.9 | PyPI | urllib3 | 2.5.0 | requirements/uv-requirements.--all-extras.txt |
> > | https://osv.dev/GHSA-gm62-xv2j-4w53 | 8.9 | PyPI | urllib3 | 2.5.0 | requirements/uv-requirements.--all-extras.txt |
> This causes `osv-scanner` to fail and the workflow to exit with code 1.
>
> ## Solution
> - Update `urllib3` in `requirements/uv-requirements.--all-extras.txt` to a secure version that resolves these advisories (see:
> - https://osv.dev/GHSA-2xpw-w6gg-jr37
> - https://osv.dev/GHSA-gm62-xv2j-4w53)
> - Re-run the workflow to verify the scan passes.
>
> ### Suggested Code Change:
> - In `requirements/uv-requirements.--all-extras.txt`, change:
> ```
> urllib3==2.5.0
> ```
> to the latest secure version. For example, if 2.5.2 or higher resolves the issue:
> ```
> urllib3==2.5.2
> ```
> - Check advisories for the correct patched version.
>
> ---
> References:
> - osv-scanner job log: failure due to vulnerabilities in urllib3
> - Job definition: .github/workflows/policy.yaml (ref: 07920c7e1715dcbe1050313093b493ee1acd3863)
>
</details>
<!-- START COPILOT CODING AGENT SUFFIX -->
*This pull request was created as a result of the following prompt from Copilot chat.*
> ## Problem Statement: Security Job Failure
> The security scan in the Check policy workflow is failing due to high-severity vulnerabilities in the `urllib3` package (v2.5.0), as seen in the logs:
> > | https://osv.dev/GHSA-2xpw-w6gg-jr37 | 8.9 | PyPI | urllib3 | 2.5.0 | requirements/uv-requirements.--all-extras.txt |
> > | https://osv.dev/GHSA-gm62-xv2j-4w53 | 8.9 | PyPI | urllib3 | 2.5.0 | requirements/uv-requirements.--all-extras.txt |
> This causes `osv-scanner` to fail and the workflow to exit with code 1.
>
> ## Solution
> - Update `urllib3` in `requirements/uv-requirements.--all-extras.txt` to a secure version that resolves these advisories (see:
> - https://osv.dev/GHSA-2xpw-w6gg-jr37
> - https://osv.dev/GHSA-gm62-xv2j-4w53)
> - Re-run the workflow to verify the scan passes.
>
> ### Suggested Code Change:
> - In `requirements/uv-requirements.--all-extras.txt`, change:
> ```
> urllib3==2.5.0
> ```
> to the latest secure version. For example, if 2.5.2 or higher resolves the issue:
> ```
> urllib3==2.5.2
> ```
> - Check advisories for the correct patched version.
>
> ---
> References:
> - osv-scanner job log: failure due to vulnerabilities in urllib3
> - Job definition: .github/workflows/policy.yaml (ref: 07920c7e1715dcbe1050313093b493ee1acd3863)
>
<!-- START COPILOT CODING AGENT TIPS -->
---
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Copilot's PR merged as commit 044ea761, bumping urllib3 2.5.0 -> 2.6.1 in uv.lock to clear GHSA-2xpw-w6gg-jr37 and GHSA-gm62-xv2j-4w53; OSV/Trivy scans passed. | |
| stealth/space-bunny-alpha | — | closed resolved | Copilot PR #1411 merged as commit 044ea761, bumping urllib3 from 2.5.0 to 2.6.1 in uv.lock to clear GHSA-2xpw-w6gg-jr37 and GHSA-gm62-xv2j-4w53 failing the OSV security scan. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1411 as commit 044ea761, updating urllib3 from 2.5.0 to 2.6.1 in uv.lock to address two high-severity security advisories. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updated urllib3 to 2.6.1 in uv.lock, resolving two high-severity vulnerabilities that failed CI security scans. No code changes needed. All checks passed and the PR was merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged update to urllib3 2.6.1, resolving two high-severity vulnerabilities that caused CI security scans to fail. Changes were limited to uv.lock with no application code modifications required. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#1430
(confidence 65%)
Later commit 1b60eff6 'build: update urllib3 (#1430)' further bumps urllib3, superseding this lockfile-only version.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #63 build: bump urllib3 | debcraft | merged | Merged PR #63 updated urllib3 to resolve an OSV vulnerability; commit 5f83429 passed all CI checks. | |
| #972 build: bump urllib3 | craft-application | merged | PR #972 merged as commit 6e9b7307, raising the urllib3 lower bound in pyproject.toml (now ">=2.8" in uv.lock) to clear an OSV vulnerability; all CI checks passed. | |
| #5912 build: bump urllib3 | snapcraft | merged | Merged PR #5912 (commit 99a19a09a) bumped urllib3 to resolve an OSV vulnerability. | |
| #5930 build: bump urllib3 | snapcraft | merged | Merged PR #5930 as commit a473ada2c, bumping urllib3 to address an OSV vulnerability. | |
| #159 build: bump urllib3 | craft-grammar | merged | Merged PR #159 (commit f6dd80b) into craft-grammar: a +3/-3 uv.lock-only bump of urllib3 to clear an OSV advisory. Approved by 2 reviewers; all CI green except the Ubuntu 24.04/Py3.10 slow tests. | |
| #344 build(deps): bump urllib3 | imagecraft | merged | Merged urllib3 dependency bump (uv.lock, +3/-3) fixing an OSV advisory; commit 033c84e landed PR #344 with 2 approvals and all CI checks green. | |
| #1408 fix(deps): update urllib3 to 2.5.1 to address security vulnerabilities | craft-parts | closed | Closed unmerged; the urllib3 security update was superseded by merged PR #1411 (commit 044ea761), which upgraded uv.lock from urllib3 2.5.0 to 2.6.1. | |
| #988 build: update urllib3 | craft-application | merged | Merged PR #988 updated urllib3 to resolve an OSV in commit 816951da; all listed CI checks passed. | |
| #165 build: bump urllib3 | craft-grammar | merged | Merged PR #165 as commit 9deba2e, bumping urllib3 in a one-file lock update to resolve an OSV advisory; all CI checks passed. | |
| #1131 build(deps): update dependency urllib3 to v2.5.0 [security] (hotfix/2.10) - autoclosed | craft-parts | closed | Autoclosed unmerged after Trivy and OSV checks failed; no urllib3 2.5.0 change landed on hotfix/2.10. A later dependency bump merged in #1135. |