← Back to issue list

fix(Makefile): remove duplicate install-rustup definition

View original Github issue

Metadata

Project
craft-parts
Number
#1429
Type
pull request
State
merged
Author
smethnani
Labels
Created
Updated
Closed

Current evaluation

Merged fix removing duplicate install-rustup Makefile target. Inverted condition to install rustup only if absent. Approved by two reviewers, passed CI, and merged with a 1-file, 10-line change.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- There are two `install-rustup` targets defined. This PR removes the second definition and inverts the condition on the remaining one to install rustup if it isn't already present.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix removing duplicate install-rustup Makefile target. Inverted condition to install rustup only if absent. Approved by two reviewers, passed CI, and merged with a 1-file, 10-line change.
qwen3.6-35b-a3b-mtp-q6 Merged a fix removing a duplicate install-rustup target from the Makefile. The remaining target condition was inverted to install rustup only when absent.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1537 build(Makefile): check for cargo craft-parts merged Merged a Makefile update that verifies cargo availability before installation, preventing duplicate installs when using the rustup snap. Approved by two reviewers and passed all CI checks.
73%