← Back to issue list

build(Makefile): check for cargo

View original Github issue

Metadata

Project
craft-parts
Number
#1537
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Merged a Makefile update that verifies cargo availability before installation, preventing duplicate installs when using the rustup snap. Approved by two reviewers and passed all CI checks.

Suggested action: —

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- If you use the rustup snap for cargo, craft-parts doesn't see that it's installed. So craft-parts will install cargo from apt and you end up with 2 copies of cargo. Now, cargo is only installed if it's not directly on the host and not available by other means.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a Makefile update that verifies cargo availability before installation, preventing duplicate installs when using the rustup snap. Approved by two reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a Makefile update that verifies existing cargo installations before attempting apt installation. This prevents duplicate cargo setups when using the rustup snap. Squash-merged by maintainer mr-cal.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#235 fix(build): update rustc and cargo imagecraft merged Merged update to rustc and cargo dependencies to ensure maturin 1.10 compatibility. Approved by two reviewers, passed all CI checks, and modified one file.
73%
#1429 fix(Makefile): remove duplicate install-rustup definition craft-parts merged Merged fix removing duplicate install-rustup Makefile target. Inverted condition to install rustup only if absent. Approved by two reviewers, passed CI, and merged with a 1-file, 10-line change.
73%
#1326 build: bump rustc/cargo to 1.91 rockcraft merged Merged changes bumping rustc and cargo to version 1.91, adopting the installation method used by Snapcraft and Charmcraft. Approved by two reviewers and passed CI checks.
72%