fix(deb): refresh apt cache before marking packages
Metadata
Current evaluation
PR #1468 by gcomneno merged as commit c2836c97: Ubuntu.install_packages now refreshes the apt cache (when install is needed) before marking packages, avoiding BuildPackageNotFound from stale indexes; added unit tests for refresh ordering/flag.
Resolution: closed resolved
Reason: The pull request was approved and merged into craft-parts main as commit c2836c97 ("fix(deb): refresh apt cache before marking packages (#1468)"); the code in craft_parts/packages/deb.py now calls refresh_packages_list() before _get_packages_marked_for_installation_apt_get(). This also closed the tracked issue canonical/craft-parts#292.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Refresh the apt package list before marking packages for installation when installation is required.
Previously, marking could fail with BuildPackageNotFound if the apt cache was stale, because apt-get update was triggered too late.
Adds unit tests to verify refresh ordering and the refresh_package_cache flag.
Related: canonical/craft-parts#292, canonical/rockcraft#1005.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1468 by gcomneno merged as commit c2836c97: Ubuntu.install_packages now refreshes the apt cache (when install is needed) before marking packages, avoiding BuildPackageNotFound from stale indexes; added unit tests for refresh ordering/flag. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1468 as commit c2836c97, refreshing the apt cache before marking packages and adding unit tests to prevent stale-cache BuildPackageNotFound errors. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix refreshing the apt cache before package marking to prevent BuildPackageNotFound errors from stale caches. Approved by three reviewers and merged after CI flakiness was confirmed as environment-related. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
15
Confidence:
90
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors. Includes unit tests. Approved by two reviewers with zero unresolved comments. CI is pending due to unrelated environment timeouts. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
85
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors. Adds unit tests. Approved by two reviewers, CI pending due to environment timeouts, contributor ready for rerun. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
20
Confidence:
85
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors. Includes unit tests. Approved by two reviewers, with CI failures attributed to environment and network issues. Awaiting maintainer rerun or merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
20
Confidence:
90
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors. Adds unit tests. Approved by two reviewers with zero unresolved comments. CI failures are environmental. Ready for maintainer review. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
15
Confidence:
90
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors. Includes unit tests. Approved by two reviewers, but currently awaiting conflict resolution and CI environment fixes. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
10
Complexity:
20
Confidence:
90
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors. PR has two approvals, all CI checks pass, and the author recently pinged maintainers indicating readiness to merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
40
Complexity:
15
Confidence:
90
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors. Includes unit tests, has one approval, zero unresolved comments, and CI checks are passing or pending. Ready for maintainer review and merge. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
15
Complexity:
15
Confidence:
85
|
needs review | Refreshes apt cache before marking packages to prevent BuildPackageNotFound errors. Includes unit tests. Currently awaiting maintainer review and CI completion, with author recently pinging for status. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
45
Complexity:
20
Confidence:
85
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors. Adds unit tests. Author addressed linting and clarified CI failures are environmental. Currently awaiting maintainer review and CI refresh. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
15
Complexity:
15
Confidence:
90
|
needs review | Fixes apt cache refresh ordering to prevent BuildPackageNotFound errors during package marking. Includes unit tests. Currently awaiting maintainer feedback after author ping; CI failures stem from environment policies, not code changes. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated |
Related work
-
Duplicate Of:
canonical/craft-parts#292
(confidence 88%)
Related long-standing issue 'auto-populate apt-cache if empty?', closed by this fix.
-
Related To:
canonical/rockcraft#1005
(confidence 60%)
Cited in the PR body as downstream context.
Related issues
No related issues found above the similarity threshold.