fix: revert organize from build
Metadata
Current evaluation
Merged in #1548 as 56282732, reverting #1535/8e4daf5 to remove organize from build after it caused a Snapcraft regression; downstream testing confirmed the fix.
Resolution: closed resolved
Reason: PR #1548 merged as commit 56282732 and fully reverted commit 8e4daf5 after it caused a Snapcraft regression. A downstream maintainer confirmed the revert fixed Snapcraft.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This reverts commit 8e4daf5dfb8c81bc6634b9d7f7f1f182cb9a99ab as
it causes a regression reported in Snapcraft. This feature will be
added back when all issues are properly solved.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1548 as 56282732, reverting #1535/8e4daf5 to remove organize from build after it caused a Snapcraft regression; downstream testing confirmed the fix. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-parts#1548, reverting 8e4daf5 to remove organize from build after a Snapcraft regression; downstream testing confirmed the fix. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to revert commit 8e4daf5, resolving a Snapcraft regression caused by the organize-from-build feature. Approved by two reviewers and verified downstream. The feature will be reintroduced once underlying issues are resolved. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to revert commit 8e4daf5, resolving a Snapcraft regression. The feature will be reintroduced after underlying issues are addressed. Downstream testing verified the fix. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/craft-parts#1535
(confidence 100%)
Its merged commit 8e4daf5 introduced organize-from-build and was fully reverted by #1548.
-
Related To:
canonical/craft-parts#1598
(confidence 90%)
Later reintroduced build source support safely as a source-only (build) pseudo-partition.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1535 feat: organize files from build | craft-parts | merged | Merged as 8e4daf5 adding (build)-partition organize support and trailing-slash destination handling for #1521; reverted by #1548 (56282732) after a Snapcraft regression, then re-landed as #1598. | |
| #1100 fix: fix organize from app -> app/app using wildcards | rockcraft | closed | PR #1100 was closed unmerged after snap-tests failed; the wildcard organize change received no completed review and never landed. | |
| #1544 fix: prevent organizing a directory into itself | craft-parts | closed | PR #1544 was closed unmerged as incomplete; the solution was replaced by the organize-from-build rework in #1598 (commit cc02958b). | |
| #1794083 Updating build with organize can result in "destination path already exists" | snapcraft (launchpad) | closed | Fixed in snapcore/snapcraft#2290 (commit 2cef6c3f6), making update builds overwrite prior organize output; #2305 was linked as the 18.10 follow-up. | |
| #1671290 organize behavior is inconsistent | snapcraft (launchpad) | closed | Closed as outdated: a maintainer noted that current Snapcraft's organize behavior has improved dramatically; no specific fixing PR or commit was cited. |