← Back to issue list

feat: organize files from build

View original Github issue

Metadata

Project
craft-parts
Number
#1535
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 8e4daf5 adding (build)-partition organize support and trailing-slash destination handling for #1521; reverted by #1548 (56282732) after a Snapcraft regression, then re-landed as #1598.

Resolution: closed resolved

Reason: The PR was merged into main as commit 8e4daf5 (approved, CRAFT-5071), closing issue #1521. The change was subsequently reverted by PR #1548 (commit 56282732, 'revert: feat: organize files from build') due to a downstream Snapcraft regression, and the feature was later re-implemented as PR #1598 (commit cc02958b).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add support for organizing files directly from a part’s build directory via the `(build)` pseudo-partition. Files cannot be organized into the build directory. Also improve destination handling for trailing slashes so non-existing `.../` destinations are treated as directories and created. Fixes #1521 CRAFT-5071 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 8e4daf5 adding (build)-partition organize support and trailing-slash destination handling for #1521; reverted by #1548 (56282732) after a Snapcraft regression, then re-landed as #1598.
stealth/space-bunny-alpha — closed superseded Merged as 8e4daf5, adding (build)-partition organization and trailing-slash handling for #1521, but was later fully reverted by #1548 (56282732) after a Snapcraft regression.
qwen/qwen3.6-35b-a3b — — Merged following reviewer approval, adding support for organizing files from a part's build directory via the (build) pseudo-partition and improving trailing slash destination handling. Resolves #1521.
qwen3.6-35b-a3b-mtp-q6 — — Merged pull request adding build pseudo-partition support to organize files from build directories, improving trailing slash handling, and reserving the build partition name with tests. Resolves #1521 and CRAFT-5071.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#1548 (confidence 98%)

    Merged revert commit 56282732 removing #1535/8e4daf5 after a Snapcraft regression.

  • Superseded By: canonical/craft-parts#1598 (confidence 95%)

    Commit cc02958b re-landed (build) pseudo-partition organize support as a source-only partition.

  • Likely Fixed By: canonical/craft-parts#1521 (confidence 90%)

    The issue this PR declares as fixing; closed with only CRAFT-5071 recorded.

Related issues

Issue Project State Summary Similarity
#1521 Organize files from build craft-parts closed Support for copying build-directory files into install partitions landed in #1598 (cc02958b), after #1535 was reverted by #1548 and the feature was re-landed.
77%
#1548 fix: revert organize from build craft-parts merged Merged in #1548 as 56282732, reverting #1535/8e4daf5 to remove organize from build after it caused a Snapcraft regression; downstream testing confirmed the fix.
76%
#54 executor: add file organization support craft-parts merged Merged #54 in commit e995c7ed, adding organize mapping support so parts can rearrange installed files; logic and tests were ported from Snapcraft.
76%
#1598 feat(organize): support build pseudo-partition source craft-parts merged Merged #1598 via commit cc02958b, adding source-only (build) organize support so build artifacts can be copied into install partitions without being removed.
75%
#1592 Refactor and integrate organize from build craft-parts closed Reintroduced organize-from-build in merged PR #1598 (commit cc02958b), with (build) as a source partition whose files are copied rather than moved.
71%
#1599709 organize feature deletes destination folder, is surprising snapcraft (launchpad) closed Organize was changed to preserve existing destination files; the fix merged in snapcraft#780 as commit 8386479e7.
71%