fix(state): track override-overlay changes
Metadata
Current evaluation
Merged fix for #1566 that tracks override-overlay changes in OverlayState.properties_of_interest() for consistent dirty checks. Approved by two reviewers, passed CI except unrelated OSV-scanner warnings, and includes focused unit tests.
Suggested action: —
No scores available.
Issue body
## Summary
Add `override-overlay` to `OverlayState.properties_of_interest()` so overlay dirty checks can report changes to the override scriptlet consistently with the other lifecycle steps.
Fixes #1566.
## Tests
- `python -m pytest -q tests/unit/state_manager/test_overlay_state.py -rs`
- `python -m pytest -q tests/unit/state_manager/test_*_state.py -rs`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for #1566 that tracks override-overlay changes in OverlayState.properties_of_interest() for consistent dirty checks. Approved by two reviewers, passed CI except unrelated OSV-scanner warnings, and includes focused unit tests. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
45
Complexity:
10
Confidence:
85
|
needs review | Tracks override-overlay in overlay state to fix inconsistent dirty checks. Open for 38 days with one comment noting an unrelated CI failure. Awaiting maintainer review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1190 fix(overlay): detect conflicts between overlay and install | craft-parts | merged | Merged fix enhancing Stage step collision detection to account for overlay contents, preventing conflicts with install directories. Includes integration tests, passed all CI checks, and received approval from three reviewers. | |
| #1473 docs: add override-overlay | craft-parts | merged | Merged documentation update adding override-overlay. Approved by three reviewers and passed CI checks despite two failing edge tests. Changes span six files with 20 additions and 8 deletions. | |
| #2068 states: track override scriptlets | snapcraft | merged | Merged changes to track override scriptlets in states, preventing untracked modifications from bypassing dirty step detection. Approved by one reviewer, passed CI, and updated 10 files (+62/-29). | |
| #1472 feat: add override-overlay | craft-parts | merged | Merged the override-overlay feature. Approved by two reviewers with 180 additions and 35 deletions across 10 files. Passed required CI checks and was successfully integrated into the codebase. | |
| #1617 fix: migrate overlay files before running stage or prime | craft-parts | merged | Merged fix that migrates overlay files before stage or prime steps. Resolves a state tracking bug causing priming failures with symlinks. Approved by reviewers and passed all CI checks. |