fix(state): track override-overlay changes
Metadata
Current evaluation
Merged in commit 059b1c0f, adding override-overlay dirty tracking and unit coverage so override scriptlet changes are detected; fixes #1566.
Resolution: closed resolved
Reason: PR #1579 was approved and merged as commit 059b1c0f. The change updates OverlayState.properties_of_interest() and adds tests for override-overlay change detection.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Summary
Add `override-overlay` to `OverlayState.properties_of_interest()` so overlay dirty checks can report changes to the override scriptlet consistently with the other lifecycle steps.
Fixes #1566.
## Tests
- `python -m pytest -q tests/unit/state_manager/test_overlay_state.py -rs`
- `python -m pytest -q tests/unit/state_manager/test_*_state.py -rs`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 059b1c0f, adding override-overlay dirty tracking and unit coverage so override scriptlet changes are detected; fixes #1566. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #1579 merged as commit 059b1c0f, adding "override-overlay" to OverlayState.properties_of_interest() so overlay dirty checks track override scriptlet changes; shipped in 2.34.0 as a bug fix and fixed issue #1566. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1579 in commit 059b1c0f, adding override-overlay to overlay dirty checks so changes to override scriptlets are detected; fixes #1566. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for #1566 that tracks override-overlay changes in OverlayState.properties_of_interest() for consistent dirty checks. Approved by two reviewers, passed CI except unrelated OSV-scanner warnings, and includes focused unit tests. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#1566
(confidence 100%)
The missing override-overlay dirty tracking reported in #1566 was explicitly fixed by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2068 states: track override scriptlets | snapcraft | merged | Merged #2068 in commit 210abedcf, tracking override scriptlets so edits mark the corresponding lifecycle steps dirty. | |
| #1472 feat: add override-overlay | craft-parts | merged | Merged #1472 (43dc8484), adding override-overlay scriptlets that run during the overlay step in a chroot, with validation and tests. | |
| #1415 feat: add override-overlay | craft-parts | merged | Merged override-overlay support via #1472 (43dc8484), adding chrooted scriptlets, validation, mounts, hashing, and tests; docs followed in #1473 for 2.30.0. | |
| #1473 docs: add override-overlay | craft-parts | merged | Merged into main as #1473 (commit 1b2b7d5a), documenting the override-overlay key and recording the feature introduced by #1472 in the changelog. | |
| #1566 OverlayState.properties_of_interest() missing 'override-overlay' | craft-parts | closed | Fixed by merged PR #1579 (commit 059b1c0f, 'fix(state): track override-overlay changes'), which added 'override-overlay' to OverlayState.properties_of_interest(); changelog notes 'Track override-overlay changes in part state'. |