← Back to issue list

states: track override scriptlets

View original Github issue

Metadata

Project
snapcraft
Number
#2068
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged changes to track override scriptlets in states, preventing untracked modifications from bypassing dirty step detection. Approved by one reviewer, passed CI, and updated 10 files (+62/-29).

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Otherwise they can change without their corresponding steps being considered dirty.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes to track override scriptlets in states, preventing untracked modifications from bypassing dirty step detection. Approved by one reviewer, passed CI, and updated 10 files (+62/-29).
qwen3.6-35b-a3b-mtp-q6 Merged implementation tracking override scriptlets. Scriptlet changes now properly trigger dirty step detection, preventing silent modifications from bypassing rebuild checks.
qwen3.6-35b-a3b-mtp-q6 Merged changes to track override scriptlets in states. This ensures scriptlet modifications correctly trigger dirty step detection, preventing silent updates without corresponding rebuilds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1579 fix(state): track override-overlay changes craft-parts merged Merged fix for #1566 that tracks override-overlay changes in OverlayState.properties_of_interest() for consistent dirty checks. Approved by two reviewers, passed CI except unrelated OSV-scanner warnings, and includes focused unit tests.
73%