← Back to issue list

states: track override scriptlets

View original Github issue

Metadata

Project
snapcraft
Number
#2068
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #2068 in commit 210abedcf, tracking override scriptlets so edits mark the corresponding lifecycle steps dirty.

Resolution: closed resolved

Reason: PR #2068 was approved and merged as commit 210abedcf. It adds state tracking for override scriptlets so changes correctly invalidate their corresponding steps.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Otherwise they can change without their corresponding steps being considered dirty.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #2068 in commit 210abedcf, tracking override scriptlets so edits mark the corresponding lifecycle steps dirty.
stealth/space-bunny-alpha — closed resolved Merged #2068 (commit 210abedcf) to track override scriptlets, ensuring changes to them mark their corresponding steps dirty.
qwen/qwen3.6-35b-a3b — — Merged changes to track override scriptlets in states, preventing untracked modifications from bypassing dirty step detection. Approved by one reviewer, passed CI, and updated 10 files (+62/-29).
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation tracking override scriptlets. Scriptlet changes now properly trigger dirty step detection, preventing silent modifications from bypassing rebuild checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1579 fix(state): track override-overlay changes craft-parts merged Merged in commit 059b1c0f, adding override-overlay dirty tracking and unit coverage so override scriptlet changes are detected; fixes #1566.
75%