← Back to issue list

fix(colcon): add missing build-packages to colcon

View original Github issue

Metadata

Project
craft-parts
Number
#1622
Type
pull request
State
merged
Author
artivis
Labels
Created
Updated
Closed

Current evaluation

Merged after resolving a changelog conflict. Fixes colcon build failures by adding missing build dependencies (make and python3-colcon-recursive-crawl) that are only recommended by default apt packages. Approved by reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

cmake only Recommends make (does not Depend on it), so it is absent when apt installs packages with --no-install-recommends, causing CMake to fail with 'CMAKE_MAKE_PROGRAM is not set' when using the default Unix Makefiles generator. Similarly, python3-colcon-recursive-crawl is only Recommended by the colcon meta-package, not depended on. It provides the 'recursive' package-discovery extension that the plugin relies on for the `--base-paths` argument to colcon build. Without it colcon rejects its own generated command line. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after resolving a changelog conflict. Fixes colcon build failures by adding missing build dependencies (make and python3-colcon-recursive-crawl) that are only recommended by default apt packages. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 10
Confidence: 85
needs review Adds missing make and python3-colcon-recursive-crawl build-packages to fix colcon CMake configuration failures when using --no-install-recommends. Currently awaiting maintainer review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3638 colcon v2: forward cmake args snapcraft merged Merged a fix ensuring colcon-cmake-args are forwarded to the build command in the Colcon v2 plugin. Approved by reviewer, passed CI, and achieved 100% diff coverage.
73%
#2687 colcon plugin: add ability to ignore packages snapcraft merged Merged. Adds ability to ignore specific packages in the colcon plugin workspace. Approved by reviewer, passed static and unit tests, and resolved static check issues before integration.
72%
#2486 colcon plugin: support build-time chaining snapcraft merged Merged PR fixing the colcon plugin to support build-time chaining. Resolves a regression by relying on setup files instead of environment variables, addressing Launchpad bug #1816565. Approved and passed CI.
71%
#2456 plugins: add colcon plugin snapcraft merged Merged the colcon plugin for ROS2 builds, resolving LP: #1805213. Added as a beta feature, the change was approved by two reviewers, passed CI with 100% diff coverage, and introduced 2120 lines across 16 files.
71%