← Back to issue list

fix(colcon): add missing build-packages to colcon

View original Github issue

Metadata

Project
craft-parts
Number
#1622
Type
pull request
State
merged
Author
artivis
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1622 in commit 3c96eba6, adding make and python3-colcon-recursive-crawl as explicit colcon build packages for minimal installs.

Resolution: closed resolved

Reason: PR #1622 was approved and merged as commit 3c96eba6. It fixes builds using --no-install-recommends by explicitly installing both missing packages.

Evaluated by: mr-cal-bot

No scores available.

Issue body

cmake only Recommends make (does not Depend on it), so it is absent when apt installs packages with --no-install-recommends, causing CMake to fail with 'CMAKE_MAKE_PROGRAM is not set' when using the default Unix Makefiles generator. Similarly, python3-colcon-recursive-crawl is only Recommended by the colcon meta-package, not depended on. It provides the 'recursive' package-discovery extension that the plugin relies on for the `--base-paths` argument to colcon build. Without it colcon rejects its own generated command line. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1622 in commit 3c96eba6, adding make and python3-colcon-recursive-crawl as explicit colcon build packages for minimal installs.
stealth/space-bunny-alpha — closed resolved Merged PR #1622 via commit 3c96eba6, adding make and python3-colcon-recursive-crawl to the colcon plugin’s build-packages for minimal apt installs.
qwen/qwen3.6-35b-a3b — — Merged after resolving a changelog conflict. Fixes colcon build failures by adding missing build dependencies (make and python3-colcon-recursive-crawl) that are only recommended by default apt packages. Approved by reviewers and passed all CI checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3638 colcon v2: forward cmake args snapcraft merged Merged PR #3638 (commit 66e385a17), forwarding colcon-cmake-args to Colcon v2's build command for plain CMake packages.
70%