colcon v2: forward cmake args
Metadata
Current evaluation
Merged a fix ensuring colcon-cmake-args are forwarded to the build command in the Colcon v2 plugin. Approved by reviewer, passed CI, and achieved 100% diff coverage.
Suggested action: —
No scores available.
Issue body
Colcon v2 plugin has a parameter, `colcon-cmake-args`, to define cmake args (for plain cmake packages). Said args were not forwarded to the build command.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix ensuring colcon-cmake-args are forwarded to the build command in the Colcon v2 plugin. Approved by reviewer, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. The colcon v2 plugin now forwards colcon-cmake-args to the build command, fixing a missing parameter forwarding bug. The change achieved 100% diff coverage and passed all tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. The Colcon v2 plugin now forwards the colcon-cmake-args parameter to the build command. The fix passed unit tests, achieved 100% diff coverage, and was integrated into the main branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2456 plugins: add colcon plugin | snapcraft | merged | Merged the colcon plugin for ROS2 builds, resolving LP: #1805213. Added as a beta feature, the change was approved by two reviewers, passed CI with 100% diff coverage, and introduced 2120 lines across 16 files. | |
| #2486 colcon plugin: support build-time chaining | snapcraft | merged | Merged PR fixing the colcon plugin to support build-time chaining. Resolves a regression by relying on setup files instead of environment variables, addressing Launchpad bug #1816565. Approved and passed CI. | |
| #1622 fix(colcon): add missing build-packages to colcon | craft-parts | merged | Merged after resolving a changelog conflict. Fixes colcon build failures by adding missing build dependencies (make and python3-colcon-recursive-crawl) that are only recommended by default apt packages. Approved by reviewers and passed all CI checks. | |
| #3265 colcon v2 plugin: honour http(s) proxy for stage-runtime-dependencies | snapcraft | merged | Merged after approval and passing CI checks. The change updates the colcon v2 plugin to honor http(s) proxy settings for stage-runtime-dependencies, modifying two files with a +13/-3 line diff. | |
| #2670 Plugin colcon: forward parallel build count | snapcraft | merged | Forwarded parallel build options to the colcon plugin. Initial CI failed due to an unrecognized --parallel-workers argument, resolved via follow-up PR #2677 and test restarts. Successfully merged after passing reviews and CI. | |
| #2687 colcon plugin: add ability to ignore packages | snapcraft | merged | Merged. Adds ability to ignore specific packages in the colcon plugin workspace. Approved by reviewer, passed static and unit tests, and resolved static check issues before integration. | |
| #1623 fix(plugins/colcon): disable test targets by default | craft-parts | merged | Merged to main after passing CI and approvals. Disables CMake test targets by default in colcon plugins via -DBUILD_TESTING=OFF, allowing user opt-in. Conflicts resolved before merge. | |
| #3358 Fix colcon v1 workspace sourcing | snapcraft | merged | Merged a fix correcting colcon v1 workspace sourcing to use the proper overlay script, resolving a build repetition issue. Approved by two reviewers, passed CI, and applied a minimal two-file change per ROS2 documentation. | |
| #1434 feat: colcon plugin | craft-parts | merged | Merged the colcon plugin into craft-parts to enable cross-tool reuse. Approved by four reviewers, the branch was rebased to resolve a conventional commit job conflict, passed CI checks, and integrated successfully. |