colcon v2: forward cmake args
Metadata
Current evaluation
Merged PR #3638 (commit 66e385a17), forwarding colcon-cmake-args to Colcon v2's build command for plain CMake packages.
Resolution: closed resolved
Reason: PR #3638 merged into main. The change adds the configured CMake arguments to the Colcon build command and includes unit coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Colcon v2 plugin has a parameter, `colcon-cmake-args`, to define cmake args (for plain cmake packages). Said args were not forwarded to the build command.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3638 (commit 66e385a17), forwarding colcon-cmake-args to Colcon v2's build command for plain CMake packages. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3638 (commit 66e385a17), forwarding colcon-cmake-args to the Colcon v2 build command for plain CMake packages. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix ensuring colcon-cmake-args are forwarded to the build command in the Colcon v2 plugin. Approved by reviewer, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. The colcon v2 plugin now forwards colcon-cmake-args to the build command, fixing a missing parameter forwarding bug. The change achieved 100% diff coverage and passed all tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4502 Colcon plugin: use release build by default | snapcraft | merged | Merged PR #4502 as commit b6c5a60b9, making Colcon use CMake Release builds by default while preserving explicit user overrides. | |
| #2670 Plugin colcon: forward parallel build count | snapcraft | merged | Merged as bd0480688; the colcon plugin now forwards parallel-build-count and disable-parallel settings to the colcon build command. | |
| #1622 fix(colcon): add missing build-packages to colcon | craft-parts | merged | Merged #1622 in commit 3c96eba6, adding make and python3-colcon-recursive-crawl as explicit colcon build packages for minimal installs. |