← Back to issue list

fix(plugins/colcon): disable test targets by default

View original Github issue

Metadata

Project
craft-parts
Number
#1623
Type
pull request
State
merged
Author
artivis
Labels
Created
Updated
Closed

Current evaluation

Merged to main after passing CI and approvals. Disables CMake test targets by default in colcon plugins via -DBUILD_TESTING=OFF, allowing user opt-in. Conflicts resolved before merge.

Suggested action:

No scores available.

Issue body

Pass `-DBUILD_TESTING=OFF` to CMake by default. Users can still opt back in by passing `-DBUILD_TESTING=ON` in `colcon-cmake-args`. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to main after passing CI and approvals. Disables CMake test targets by default in colcon plugins via -DBUILD_TESTING=OFF, allowing user opt-in. Conflicts resolved before merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 10
Confidence: 90
needs review Passes -DBUILD_TESTING=OFF to CMake by default in the Colcon plugin, allowing users to opt back in. Currently awaiting maintainer review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3638 colcon v2: forward cmake args snapcraft merged Merged a fix ensuring colcon-cmake-args are forwarded to the build command in the Colcon v2 plugin. Approved by reviewer, passed CI, and achieved 100% diff coverage.
71%
#2476 tests: disable spread colcon tests snapcraft merged Merged a pull request temporarily disabling spread colcon tests after upstream changes broke the plugin. Approved and merged to maintain CI stability while the upstream issue is resolved.
71%