← Back to issue list

fix(plugins/colcon): disable test targets by default

View original Github issue

Metadata

Project
craft-parts
Number
#1623
Type
pull request
State
merged
Author
artivis
Labels
—
Created
Updated
Closed

Current evaluation

PR #1623 (artivis) merged as commit 64d6c049: the colcon plugin now injects -DBUILD_TESTING=OFF into colcon CMake args by default, skipped if the user sets BUILD_TESTING in colcon-cmake-args; docs, changelog and unit tests updated.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 64d6c049 ("fix(plugins/colcon): disable test targets by default (#1623)") after approval from 3 reviewers. The change in craft_parts/plugins/colcon_plugin.py appends -DBUILD_TESTING=OFF unless a colcon-cmake-arg already starts with -DBUILD_TESTING, and the changelog entry confirms the new default plus the opt-back-in path.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Pass `-DBUILD_TESTING=OFF` to CMake by default. Users can still opt back in by passing `-DBUILD_TESTING=ON` in `colcon-cmake-args`. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1623 (artivis) merged as commit 64d6c049: the colcon plugin now injects -DBUILD_TESTING=OFF into colcon CMake args by default, skipped if the user sets BUILD_TESTING in colcon-cmake-args; docs, changelog and unit tests updated.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-parts#1623 in 64d6c049, defaulting the colcon plugin to -DBUILD_TESTING=OFF while allowing opt-in through colcon-cmake-args.
qwen/qwen3.6-35b-a3b — — Merged to main after passing CI and approvals. Disables CMake test targets by default in colcon plugins via -DBUILD_TESTING=OFF, allowing user opt-in. Conflicts resolved before merge.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#1434 (confidence 70%)

    PR #1434 added the colcon plugin whose cmake-arg defaults (CMAKE_BUILD_TYPE=Release, BUILD_TESTING=OFF) this PR extends.

  • Related To: craft-parts#1622 (confidence 45%)

    Adjacent colcon plugin fix merged shortly before (commit 3c96eba6); no direct dependency on this change.

Related issues

Issue Project State Summary Similarity
#2476 tests: disable spread colcon tests snapcraft merged Merged #2476 in commit 0eb9f2337, temporarily disabling spread colcon tests after upstream changes broke the plugin.
71%