← Back to issue list

refactor: format partition errors inside error class

View original Github issue

Metadata

Project
craft-parts
Number
#1714
Type
pull request
State
open
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Refactors partition error classes to receive unformatted data structures instead of pre-formatted strings. Fixes craft-parts#670. PR is 0 days old with pending CI checks and 2 unresolved review comments.

Suggested action: needs review

Reason: This is a brand new PR (0 days old) authored by a maintainer (cmatsuoka) that refactors partition error classes to receive unformatted data structures, fixing issue #670. It has 2 unresolved review comments and several pending CI checks, indicating it is actively under review and not yet ready to merge.

Impact: 25 Quick Win: 17.5 Staleness: 0 Complexity: 30 Confidence: 70

Issue body

Refactor partition-related error classes to receive unformatted data structures. Fixes #670 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 25
Quick Win: 17.5
Staleness: 0
Complexity: 30
Confidence: 70
needs review Refactors partition error classes to receive unformatted data structures instead of pre-formatted strings. Fixes craft-parts#670. PR is 0 days old with pending CI checks and 2 unresolved review comments.
qwen/qwen3.6-35b-a3b
Impact: 25
Quick Win: 18.75
Staleness: 5
Complexity: 25
Confidence: 75
needs review Refactors partition error classes to format messages internally instead of callers passing pre-indented strings. Fresh PR with 2 unresolved review comments and mostly passing CI.
qwen/qwen3.6-35b-a3b
Impact: 25
Quick Win: 18.75
Staleness: 5
Complexity: 25
Confidence: 80
needs review Refactors partition error classes to accept unformatted data structures and format internally. Fresh PR, 0 comments, 0 reviewers, CI passing.

Update history

Date Change
updated
updated
created

Related work

  • Related To: craft-parts#670 (confidence 95%)

    The PR explicitly references this issue as the fix target. The issue describes the same refactor task and has been open since 2024-05-17 with no prior maintainer activity.

Related issues

Issue Project State Summary Similarity
#670 Format partition warnings and errors inside the error class craft-parts open Refactor task: partition warning/error classes should format indented messages internally instead of callers passing pre-indented strings. Unlabeled, no maintainer activity since 2024-05-17; code at HEAD still passes indented strings, so the work remains unaddressed.
71%