refactor: format partition errors inside error class
Metadata
Current evaluation
Maintainer-authored refactor (canonical/craft-parts#1714, fixes #670) moving partition error/warning message formatting from parts.py into PartitionUsageError/PartitionWarning classes so they receive unformatted data. +138/-42 across 5 files; all completed CI checks green, several slow suites pending, 2 unresolved review comments.
Suggested action: needs review
Reason: The diff is a contained internal refactor (+138/-42, 5 files) with no user-facing behavior change intended, so impact stays modest; CI shows no failing checks (passing: test-common / Fast tests, test-requires-root, test-python-plugins-jammy, plus policy/security gates) with only slow-arch matrix jobs still pending. Review status is 'pending (0 reviewers)' with 2 unresolved review comments, so it is not merge-ready but is actively awaiting maintainer/reviewer attention rather than abandoned — last activity 12 days ago on a 24-day-old maintainer PR. Confidence is capped at 72 because the code-inspection tools were unavailable (no pinned SHA for craft-parts), so I could not verify the error classes' call sites or test updates, and the 2 unresolved comments cannot be read.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
25
Quick Win:
9
Complexity:
40
Confidence:
72
Actionability:
58
|
needs review | Maintainer-authored refactor (canonical/craft-parts#1714, fixes #670) moving partition error/warning message formatting from parts.py into PartitionUsageError/PartitionWarning classes so they receive unformatted data. +138/-42 across 5 files; all completed CI checks green, several slow suites pending, 2 unresolved review comments. | |
| stealth/space-bunny-alpha |
Impact:
30
Quick Win:
10
Complexity:
38
Confidence:
87
Actionability:
55
|
needs review | Partition error/warning classes are refactored to format structured input internally for #670; no CI failures are reported, but two review comments remain unresolved and several jobs are pending. | |
| qwen/qwen3.6-35b-a3b |
Impact:
25
Quick Win:
18
Staleness:
0
Complexity:
30
Confidence:
70
|
needs review | Refactors partition error classes to receive unformatted data structures instead of pre-formatted strings. Fixes craft-parts#670. PR is 0 days old with pending CI checks and 2 unresolved review comments. | |
| qwen/qwen3.6-35b-a3b |
Impact:
25
Quick Win:
19
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Refactors partition error classes to format messages internally instead of callers passing pre-indented strings. Fresh PR with 2 unresolved review comments and mostly passing CI. | |
| qwen/qwen3.6-35b-a3b |
Impact:
25
Quick Win:
19
Staleness:
5
Complexity:
25
Confidence:
80
|
needs review | Refactors partition error classes to accept unformatted data structures and format internally. Fresh PR, 0 comments, 0 reviewers, CI passing. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/craft-parts#670
(confidence 95%)
PR body states 'Fixes #670', an open maintainer-authored issue to format partition warnings and errors inside the error class; this PR is the implementation of that issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #670 Format partition warnings and errors inside the error class | craft-parts | open | Maintainer-authored refactor: pass unformatted partition warning/error data to PartitionUsageError/Warning and let the error classes do the indenting, instead of building pre-indented strings in parts.py. Still open, unlabelled, only a Jira sync bot comment. | |
| #1591 fix(errors): generalize partition usage resolution | craft-parts | merged | Merged PR #1591 (commit 5d96832f) generalized PartitionUsageError guidance for all invalid partition usage, fixed #836, and shipped in craft-parts 2.36.0. |