← Back to issue list

fix(errors): generalize partition usage resolution

View original Github issue

Metadata

Project
craft-parts
Number
#1591
Type
pull request
State
merged
Author
gcomneno
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1591 (commit 5d96832f) generalized PartitionUsageError guidance for all invalid partition usage, fixed #836, and shipped in craft-parts 2.36.0.

Resolution: closed resolved

Reason: PR #1591 was approved and merged, replacing name-specific corrective guidance with resolution text for invalid partition usage generally. The fix is documented in the 2.36.0 changelog.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Summary Generalize the `PartitionUsageError` resolution text so it no longer tells users to correct partition names when the invalid usage may be unrelated to partition names. Fixes #836. ## Tests - `python -m pytest -q tests/unit/test_errors.py -k partition -rs`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1591 (commit 5d96832f) generalized PartitionUsageError guidance for all invalid partition usage, fixed #836, and shipped in craft-parts 2.36.0.
stealth/space-bunny-alpha — closed resolved Merged PR #1591 (commit 5d96832f) generalized PartitionUsageError guidance to cover invalid partition usage, not only incorrect names, resolving #836.
qwen/qwen3.6-35b-a3b — — Merged changes generalizing the PartitionUsageError resolution text to prevent misleading guidance about partition names. Approved by two reviewers, passed CI, and resolves #836. A changelog entry was requested.
qwen/qwen3.6-35b-a3b
Staleness: 55
Complexity: 10
Confidence: 75
needs review Generalizes PartitionUsageError resolution text to avoid misleading users about partition names. Currently awaiting maintainer review with zero comments. CI is mostly passing with minor flaky test failures.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 10
Confidence: 85
needs review Generalizes PartitionUsageError resolution text to avoid incorrectly suggesting partition name corrections. Fixes #836. Includes a unit test. Currently awaiting maintainer review after 49 days of inactivity.

Update history

Date Change
updated
updated
updated

Related work

  • Related To: craft-parts#836 (confidence 100%)

    The incorrect partition error message reported in #836 was fixed by PR #1591.

Related issues

Issue Project State Summary Similarity
#836 Incorrect partition error message craft-parts closed Generalized PartitionUsageError guidance in merged PR #1591 (commit 5d96832f), released in 2.36.0, so it covers invalid partition usage beyond incorrect names.
79%
#493 partitions: validate usage of partitions in parts craft-parts merged Merged into craft-parts in commit ed20df71 (#493), adding validation of partition usage in filepaths for parts' organize, overlay, stage and prime keywords (CRAFT-1844).
74%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged into main in commit f387afa5 (PR #600), adding namespaced-partition handling to four partition utilities and resolving craft-parts#596.
73%
#801 fix: partitions break when using special characters craft-parts merged Merged PR #801 fixed CRAFT-3031 lifecycle failures for partition names containing numbers and hyphens; merged as commit ceaf4cda.
72%
#1714 refactor: format partition errors inside error class craft-parts open Maintainer-authored refactor (canonical/craft-parts#1714, fixes #670) moving partition error/warning message formatting from parts.py into PartitionUsageError/PartitionWarning classes so they receive unformatted data. +138/-42 across 5 files; all completed CI checks green, several slow suites pending, 2 unresolved review comments.
70%