← Back to issue list

feat: better error message for cache prepare failure

View original Github issue

Metadata

Project
craft-parts
Number
#1720
Type
pull request
State
open
Author
cmatsuoka
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds a wrapped PartsError with actionable guidance when APT stage-cache preparation fails (e.g. sudo/non-sudo mixups). Fixes #648; all CI checks green, 2 unresolved comments, no changelog entry yet.

Suggested action: needs review

Reason: All listed checks pass (including policy, CLA, security scans) and the change targets the exact gap in craft-parts#648 ('wrap the apt cache rmtree in _populate_stage_cache_dir with try/except', tracked as CRAFT-2937), matching the observed code at craft_parts/packages/apt_cache.py:153 where shutil.rmtree/copytree on etc/apt are unwrapped. However the PR is 'pending (0 reviewers)' with 2 unresolved review comments, and the author left 'added an entry to the changelog' and 'run make lint && make test' unchecked, so it needs a final maintainer pass before landing.

Evaluated by: mr-cal-bot

Impact: 40 Quick Win: 21 Complexity: 25 Confidence: 78 Actionability: 70

Issue body

Catch errors in apt cache preparation. An example error message would look like this: Cannot prepare the package cache. Failed to prepare the APT cache at <path>: Permission denied. This is usually caused by running the application with sudo and then without. Remove the cache directory manually or run the application with the same privileges. Fixes #648 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 40
Quick Win: 21
Complexity: 25
Confidence: 78
Actionability: 70
needs review Adds a wrapped PartsError with actionable guidance when APT stage-cache preparation fails (e.g. sudo/non-sudo mixups). Fixes #648; all CI checks green, 2 unresolved comments, no changelog entry yet.
stealth/space-bunny-alpha
Impact: 45
Quick Win: 24
Complexity: 28
Confidence: 88
Actionability: 74
needs review Adds clearer APT cache preparation errors with privilege-change guidance. CI is green, but maintainer review is pending with two unresolved comments and no changelog entry.
stealth/space-bunny-alpha
Impact: 42
Quick Win: 17
Complexity: 29
Confidence: 90
Actionability: 58
needs review Adds clearer diagnostics when APT cache preparation fails, including guidance for privilege-related ownership problems. All CI checks pass; review is pending with two unresolved comments.
stealth/space-bunny-alpha
Impact: 45
Quick Win: 19
Complexity: 35
Confidence: 84
Actionability: 66
needs review Adds a targeted permission error for APT cache preparation failures, with remediation guidance; all 29 checks pass, but two review comments remain unresolved and no maintainer review is recorded.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 35
Staleness: 5
Complexity: 30
Confidence: 80
needs review Improves error messages when apt cache preparation fails (e.g., permission denied from sudo/normal user confusion). Fixes craft-parts#648. All CI passing, 2 unresolved review comments, 0 reviewers.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 35
Staleness: 5
Complexity: 30
Confidence: 75
needs review Improves error messages when apt cache preparation fails, addressing issue #648. All CI checks pass; awaiting maintainer review.
qwen/qwen3.6-35b-a3b
Impact: 35
Quick Win: 30
Staleness: 5
Complexity: 15
Confidence: 85
needs review Improves error messages when apt cache preparation fails, addressing issue #648. PR is fresh, CI passing, awaiting review.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 38
Staleness: 5
Complexity: 25
Confidence: 75
needs review Adds better error messages for apt cache preparation failures, fixing craft-parts#648. PR is 1 day old with passing CI checks and no reviewer engagement yet.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 32
Staleness: 5
Complexity: 35
Confidence: 75
needs review Adds better error messages when apt cache preparation fails, addressing issue #648. Fresh PR from maintainer cmatsuoka, pending review with failing CI tests.
qwen/qwen3.6-35b-a3b
Impact: 40
Quick Win: 34
Staleness: 0
Complexity: 15
Confidence: 70
needs review Adds better error messages when apt cache preparation fails, addressing issue #648. Fresh PR with a failing lint check, awaiting review.
qwen/qwen3.6-35b-a3b
Impact: 40
Quick Win: 34
Staleness: 0
Complexity: 15
Confidence: 85
needs review Adds better error messages for apt cache preparation failures. PR is fresh, authored by maintainer, CI passing, awaiting review.

Update history

Date Change
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: craft-parts#648 (confidence 95%)

    Issue explicitly requests this error wrapping; PR body says 'Fixes #648'. The issue remains open, so this PR is its implementation.

Related issues

No related issues found above the similarity threshold.