feat: validate required build-slices
Metadata
Current evaluation
Merged PR #1767 adding validation for required build-slices to improve error messages, resolving #1744.
Resolution: closed resolved
Reason: The pull request was merged, implementing validation for required build-slices to replace unhelpful error messages, directly resolving issue #1744.
Evaluated by: mr-cal-bot
No scores available.
Issue body
If any part declares `build-slices`, craft-parts will validate that all required build slices are defined.
The previous error was not user-friendly ([source](https://github.com/canonical/craft-application/pull/1188#discussion_r4096810621)).
Fixes #1744
(CRAFT-5328)
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-parts/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [x] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR #1767 adding validation for required build-slices to improve error messages, resolving #1744. | |
| ~deepseek/deepseek-pro-latest |
Impact:
50
Quick Win:
20
Complexity:
35
Confidence:
75
Actionability:
60
|
needs review | Adds validation that any part declaring build-slices must include required base-files_bin and bash_bins slices, replacing an opaque chroot error. Approved with unresolved review comments; OSV-scanner CI failing. | |
| ~deepseek/deepseek-pro-latest |
Impact:
50
Quick Win:
18
Complexity:
40
Confidence:
65
Actionability:
60
|
needs review | Adds validation that required build-slices (base-files_bin, bash_bins) are declared when any part uses build-slices; fixes #1744. Approved with 2 unresolved review comments; OSV-scanner CI failing. | |
| ~deepseek/deepseek-pro-latest |
Impact:
50
Quick Win:
16
Complexity:
45
Confidence:
60
Actionability:
60
|
needs review | Adds validation that required build-slices (base-files_bin, bash_bins) are declared when any part uses build-slices; fixes #1744. Approved with 2 unresolved review comments; OSV-scanner CI failing. | |
| ~deepseek/deepseek-pro-latest |
Impact:
50
Quick Win:
18
Complexity:
40
Confidence:
70
Actionability:
60
|
needs review | Adds validation that required build-slices (base-files_bin, bash_bins) are declared when any part uses build-slices; fixes #1744. CI mostly green but OSV-scanner failing and one unresolved review comment. | |
| ~deepseek/deepseek-pro-latest |
Impact:
55
Quick Win:
20
Complexity:
40
Confidence:
65
Actionability:
60
|
needs review | Adds validation that required build-slices are present when any part declares build-slices; updates tests and release notes, OSV-scanner failing and slow tests pending. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Likely Fixed By:
craft-parts#1744
(confidence 100%)
Issue #1744 was explicitly referenced as fixed by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1758 feat: track build-slices in part state | craft-parts | merged | Merged PR #1758 adds build-slices to BuildState properties_of_interest so the build step invalidates when build-slices changes; updates tests. | |
| #1744 Present a better error when missing critical build-slices | craft-parts | closed | Fixed in #1767 by adding validation that parts using build-slices must include base-files_bin and bash_bins, replacing the opaque chroot error with a clear message. | |
| #1717 feat(part): add build-slices model | craft-parts | closed | Merged PR #1717 as 758e822a, adding a feature-gated build-slices Part model and validation; build-slices support shipped in 2.37.0. |