← Back to issue list

feat: track build-slices in part state

View original Github issue

Metadata

Project
craft-parts
Number
#1758
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1758 adds build-slices to BuildState properties_of_interest so the build step invalidates when build-slices changes; updates tests.

Resolution: closed resolved

Reason: The PR was merged by the author (cmatsuoka, a maintainer). The change adds build-slices tracking to part state to invalidate the build step when the value changes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add build-slices to build state to invalidate the step in case the value changes. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-parts/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #1758 adds build-slices to BuildState properties_of_interest so the build step invalidates when build-slices changes; updates tests.
~deepseek/deepseek-pro-latest
Impact: 55
Quick Win: 21
Complexity: 35
Confidence: 65
Actionability: 60
needs review Adds build-slices to BuildState properties_of_interest so the build step invalidates when build-slices changes; updates tests. Under review, OSV-scanner failing.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 16
Complexity: 30
Confidence: 60
Actionability: 45
needs review Adds build-slices to BuildState properties_of_interest so build step invalidates when build-slices changes; updates tests. CI has OSV-scanner failure and one unresolved review comment.
~deepseek/deepseek-pro-latest
Impact: 55
Quick Win: 20
Complexity: 35
Confidence: 70
Actionability: 55
needs review Adds build-slices to BuildState properties of interest so changing the value invalidates the build step. Under review; OSV-scanner CI failing, many tests pending.
~deepseek/deepseek-pro-latest
Impact: 55
Quick Win: 11
Complexity: 35
Confidence: 60
Actionability: 30
keep open Adds build-slices to BuildState properties of interest so build step reruns when slices change; CI failing test-common and OSV-scanner, one unresolved review comment.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 12
Complexity: 30
Confidence: 70
Actionability: 35
keep open Adds build-slices to BuildState properties of interest so the build step invalidates when the value changes. Open with failing slow tests and OSV-scanner, one unresolved review comment.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 12
Complexity: 40
Confidence: 60
Actionability: 40
keep open Adds build-slices to BuildState properties of interest so the build step invalidates when the value changes. Open with failing slow tests and OSV-scanner, one unresolved review comment.
~deepseek/deepseek-pro-latest
Impact: 55
Quick Win: 11
Complexity: 35
Confidence: 70
Actionability: 30
keep open Adds build-slices to BuildState properties of interest so the build step invalidates when the value changes. CI failing lint/files and several test jobs; one unresolved review comment.
~deepseek/deepseek-pro-latest
Impact: 55
Quick Win: 10
Complexity: 50
Confidence: 65
Actionability: 35
keep open Adds build-slices to BuildState so the build step invalidates when the value changes. 8 files, +83/-12. CI failing lint/files and several test jobs; lint/test checklist unchecked.
~deepseek/deepseek-pro-latest
Impact: 55
Quick Win: 12
Complexity: 30
Confidence: 65
Actionability: 30
keep open Adds build-slices to BuildState properties of interest so the build step invalidates when the value changes. CI failing lint/files and test-common; one unresolved review comment.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 9
Complexity: 40
Confidence: 78
Actionability: 30
keep open Adds build-slices to BuildState properties of interest so the build step invalidates when the value changes. CI is failing and one review comment is unresolved.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 13
Complexity: 25
Confidence: 70
Actionability: 35
keep open Adds build-slices to BuildState properties of interest so the build step invalidates when the value changes. CI failing lint/tests and one unresolved review comment remain.
~deepseek/deepseek-pro-latest
Impact: 55
Quick Win: 12
Complexity: 30
Confidence: 60
Actionability: 30
keep open Adds build-slices to BuildState properties of interest so the build step invalidates when the value changes. CI failing lint/tests and 1 unresolved review comment.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 11
Complexity: 25
Confidence: 70
Actionability: 30
keep open Adds build-slices to build state properties of interest so changing build-slices invalidates the build step; CI failing lint/files and OSV-scanner.

Update history

Date Change
merged
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1717 feat(part): add build-slices model craft-parts closed Merged PR #1717 as 758e822a, adding a feature-gated build-slices Part model and validation; build-slices support shipped in 2.37.0.
76%
#1767 feat: validate required build-slices craft-parts merged Merged PR #1767 adding validation for required build-slices to improve error messages, resolving #1744.
75%
#1718 feat: cut build-slices in the prologue craft-parts closed Merged as commit 2adcb0c1. Executor prologue now collects build-slices from all parts, de-duplicates them into a single chisel cut, with a state file to skip unchanged re-cuts; unit and integration tests added.
73%
#1724 feat: run 'build' in build-slices root craft-parts closed Merged PR #1724 as commit 07a32ae8, enabling build to run in the build-slices root after slice model and prologue work in #1717 and #1718.
73%
#1188 feat: add build-slice support, top-level build-slice key craft-application closed Merged #1188, adding AppMetadata.enable_build_slices and top-level build-slices support; empty or null values are now a no-op.
73%