Add FTP source download support
Metadata
Current evaluation
Adds FTP source download support by implementing the previously NotImplementedError FTP handler in base.py; PR is open, CI passing, awaiting first review from maintainers.
Suggested action: needs review
Reason: This PR implements FTP source download support, replacing the existing NotImplementedError('ftp download not implemented') in craft_parts/sources/base.py with actual FTP download logic. It is a new feature from an external contributor, 3 days old, with 0 reviewer comments and passing CI. It needs maintainer review before merge.
Evaluated by: mr-cal-bot
Impact:
55
Quick Win:
23
Complexity:
30
Confidence:
70
Actionability:
60
Issue body
Describe your changes.
---
- [ ] I've followed the [contribution guidelines](https://github.com/canonical/craft-parts/blob/main/CONTRIBUTING.md).
- [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
23
Complexity:
30
Confidence:
70
Actionability:
60
|
needs review | Adds FTP source download support by implementing the previously NotImplementedError FTP handler in base.py; PR is open, CI passing, awaiting first review from maintainers. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1546 Support download part source from FTP URLs | craft-parts | open | Feature request to support downloading part sources from FTP URLs; the code still raises NotImplementedError and the issue has no maintainer triage or comments. |