← Back to issue list

plugins: validate dependencies

View original Github issue

Metadata

Project
craft-parts
Number
#197
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #197 via ed3c56e7 (cf5769ad), consolidating plugin dependency validation ahead of conda, npm, and Rust plugins with no functional changes.

Resolution: closed resolved

Reason: The approved refactor was merged into the main branch by commit ed3c56e7, with implementation commit cf5769ad.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Laying groundwork prior to adding the plugins `conda`, `npm`, and `rust`. Redundant code for validating plugin dependencies has been normalized in the validator class. (Don't Repeat Yourself) No functional changes. (CRAFT-1019)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #197 via ed3c56e7 (cf5769ad), consolidating plugin dependency validation ahead of conda, npm, and Rust plugins with no functional changes.
stealth/space-bunny-alpha — closed resolved Merged craft-parts PR #197 via ed3c56e7 (cf5769ad), consolidating plugin dependency validation ahead of conda, npm, and rust plugins, with no functional changes.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI. Normalized plugin dependency validation logic in the validator class to prepare for conda, npm, and rust plugins. Refactored 7 files (+75/-121 lines) with no functional changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged normalization of plugin dependency validation code in the validator class, applying DRY principles. Prepares groundwork for upcoming conda, npm, and rust plugins without functional changes. Author acknowledged review feedback for future refactoring.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#224 plugin: plugin validation with only one part dep craft-parts merged Merged PR #224 in commit 098bb5c5, limiting plugin validation to one part dependency and skipping verification for excluded nodes.
73%