← Back to issue list

plugins: validate dependencies

View original Github issue

Metadata

Project
craft-parts
Number
#197
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and CI. Normalized plugin dependency validation logic in the validator class to prepare for conda, npm, and rust plugins. Refactored 7 files (+75/-121 lines) with no functional changes.

Suggested action:

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Laying groundwork prior to adding the plugins `conda`, `npm`, and `rust`. Redundant code for validating plugin dependencies has been normalized in the validator class. (Don't Repeat Yourself) No functional changes. (CRAFT-1019)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and CI. Normalized plugin dependency validation logic in the validator class to prepare for conda, npm, and rust plugins. Refactored 7 files (+75/-121 lines) with no functional changes.
qwen3.6-35b-a3b-mtp-q6 Merged normalization of plugin dependency validation code in the validator class, applying DRY principles. Prepares groundwork for upcoming conda, npm, and rust plugins without functional changes. Author acknowledged review feedback for future refactoring.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#221 plugins: make plugin options available in validator craft-parts merged Merged changes that expose plugin options to environment validators. Approved by one reviewer, passed CI checks, and updated 11 files (+101/-35 lines).
74%
#150 plugins: add plugin environment validation (CRAFT-611) craft-parts merged Added plugin environment validators to verify system requirements before building parts. Merged after reviewer approval and passing CI checks, modifying 14 files with 629 additions and 23 deletions.
74%
#224 plugin: plugin validation with only one part dep craft-parts merged Merged after reviewer approval and passing CI. Updated plugin validation for single-part dependencies and fixed node verification to skip checks when nodes are included. The provisional solution was accepted for integration.
73%
#3703 plugins: (new) conda snapcraft merged Merged into snapcraft/7.0, adding a new conda plugin. Approved by a reviewer, passed CI checks, and increased coverage by 0.22%. The change modifies 11 files with 536 additions and 4 deletions.
71%
#71 plugins: check presence of required part properties (CRAFT-74) craft-parts merged Merged after two approvals and passing CI. Replaces manual verification of required plugin properties, such as source, with Pydantic validation. Updated nine files (+78/-25 lines) to enforce property requirements during plugin configuration.
70%