← Back to issue list

plugin: plugin validation with only one part dep

View original Github issue

Metadata

Project
craft-parts
Number
#224
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after reviewer approval and passing CI. Updated plugin validation for single-part dependencies and fixed node verification to skip checks when nodes are included. The provisional solution was accepted for integration.

Suggested action:

No scores available.

Issue body

Setup plugin validation so it only mentions a dependency on one part. This is still not the best solution to the problem. Also fixup the node verification for it to check if node is to be included and if so, skip verification. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- I am not entirely happy with this solution. Proposing for discussion.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after reviewer approval and passing CI. Updated plugin validation for single-part dependencies and fixed node verification to skip checks when nodes are included. The provisional solution was accepted for integration.
qwen3.6-35b-a3b-mtp-q6 Merged updates to plugin validation for single-part dependencies and corrected node verification to bypass checks when nodes are included. The maintainer accepted the workaround despite noting it as a temporary solution.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#197 plugins: validate dependencies craft-parts merged Merged after approval and CI. Normalized plugin dependency validation logic in the validator class to prepare for conda, npm, and rust plugins. Refactored 7 files (+75/-121 lines) with no functional changes.
73%
#150 plugins: add plugin environment validation (CRAFT-611) craft-parts merged Added plugin environment validators to verify system requirements before building parts. Merged after reviewer approval and passing CI checks, modifying 14 files with 629 additions and 23 deletions.
71%
#277 parts: add part validator craft-parts merged Merged adds a centralized part validation helper that validates data against part and plugin models, replacing per-tool logic. Approved, passed CI, and resolves issue #176.
71%