fix: parts: check for out of source builds
Metadata
Current evaluation
Closed unmerged and superseded by #250, merged as bd512ef3 (implementation b7775ebb), fixing source-subdir handling for out-of-source CMake and Meson builds (CRAFT-1185).
Resolution: closed superseded
Reason: PR #248 was replaced by PR #250. PR #250 was merged in commit bd512ef3 with implementation commit b7775ebb, fixing CRAFT-1185.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Plugins that supported out-of-source building were not working with the `source-subdir` parameter.
There were two minor issues:
- A missing check for out-of-source plugins when determining the build directory
- cmake and meson plugins not choosing the right source directory
Unfortunately, accessing the `out_of_source_build` property prior to instantiating the plugin was a challenge. I've made some comments below.
(CRAFT-1185)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and superseded by #250, merged as bd512ef3 (implementation b7775ebb), fixing source-subdir handling for out-of-source CMake and Meson builds (CRAFT-1185). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and superseded by #250, which landed the out-of-source/source-subdir fix in commit b7775ebb, merged as bd512ef3. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and superseded by #250, which fixed source-subdir handling for out-of-source builds and merged as bd512ef3 (fix commit b7775ebb). | |
| stealth/space-bunny-alpha | — | closed superseded | PR #248 was closed unmerged and superseded by #250, which fixed source-subdir handling for out-of-source builds in commit b7775ebb (CRAFT-1185). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix out-of-source build detection in cmake and meson plugins, resolving source directory selection issues with the source-subdir parameter. Addresses CRAFT-1185. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix addressing out-of-source build failures with the source-subdir parameter. Corrected build directory detection and resolved cmake and meson source directory selection issues. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-parts#250
(confidence 100%)
The successor PR implemented and merged the same out-of-source build and source-subdir fixes.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #250 parts: check for out of source builds | craft-parts | merged | Merged #250 via bd512ef3, fixing out-of-source build detection and CMake/Meson source-directory selection when source-subdir is set (CRAFT-1185). |