parts: check for out of source builds
Metadata
Current evaluation
Merged #250 via bd512ef3, fixing out-of-source build detection and CMake/Meson source-directory selection when source-subdir is set (CRAFT-1185).
Resolution: closed resolved
Reason: PR #250 was merged into the main branch in merge commit bd512ef3, with the implementation committed as b7775ebb. The change added the missing out-of-source plugin check and corrected CMake and Meson source-directory selection.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Plugins that supported out-of-source building were not working with the source-subdir parameter.
There were two minor issues:
1. A missing check for out-of-source plugins when determining the build directory
2. `cmake` and `meson` plugins not choosing the right source directory
Unfortunately, accessing the out_of_source_build property prior to instantiating the plugin was a challenge. I've made some comments below.
(CRAFT-1185)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #250 via bd512ef3, fixing out-of-source build detection and CMake/Meson source-directory selection when source-subdir is set (CRAFT-1185). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #250 (bd512ef3), fixing out-of-source build detection and CMake/Meson source-directory selection when source-subdir is set (CRAFT-1185). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for out-of-source builds with the source-subdir parameter. Added missing out-of-source checks and corrected source directory selection for cmake and meson plugins. Approved, passed CI, and merged with 221 additions and 24 deletions across 22 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for out-of-source plugin builds. Added missing build directory validation and corrected cmake and meson plugins to select the correct source directory, resolving CRAFT-1185. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #248 fix: parts: check for out of source builds | craft-parts | closed | Closed unmerged and superseded by #250, merged as bd512ef3 (implementation b7775ebb), fixing source-subdir handling for out-of-source CMake and Meson builds (CRAFT-1185). |