← Back to issue list

plugins: fix cmake plugin prefix

View original Github issue

Metadata

Project
craft-parts
Number
#263
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged #263 as 71b71990 (implementation 78036efe), fixing CMake prefix-path formatting and matching installation prefix behavior to v1 plugins (CRAFT-1154).

Resolution: closed resolved

Reason: PR #263 was approved and merged into main as commit 71b71990, with the fix implemented in commit 78036efe.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Properly format the cmake prefix path string, and set the installation prefix to match v1 plugins. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1154

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #263 as 71b71990 (implementation 78036efe), fixing CMake prefix-path formatting and matching installation prefix behavior to v1 plugins (CRAFT-1154).
stealth/space-bunny-alpha — closed resolved Merged #263 as commit 71b71990, fixing CMake prefix-path formatting and aligning the installation prefix with v1 plugins (CRAFT-1154).
qwen/qwen3.6-35b-a3b — — Merged after two approvals and passing CI. Fixed cmake plugin prefix path formatting and aligned the installation prefix with v1 plugins. Rebased on main.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the cmake plugin prefix. The change properly formats the prefix path string and aligns the installation prefix with v1 plugins. Claudio Matsuoka amended and rebased the commit on main prior to merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#267 plugins: drop cmake install prefix argument craft-parts merged Merged in canonical/craft-parts#267, dropping the CMake plugin's default CMAKE_INSTALL_PREFIX to preserve core22 usr/local/bin behavior while allowing an explicit prefix.
77%
#184 plugins: cmake craft-parts merged Merged the CMake plugin port into craft-parts via PR #184, merge commit 57744f7a, with implementation commit 9ceb1fc8.
73%
#346 CMake plugin: Support installing via prefix. snapcraft closed Closed unmerged after the change was found to target CMake instead of Autotools; equivalent prefix-install support merged in snapcraft#351 via commit 72dbc3285.
71%
#266 Release 1.12.0 craft-parts merged Merged release PR #266 as b376ea29, publishing craft-parts 1.12.0 with CMake install-prefix and prefix-path fixes from PR #263.
70%