← Back to issue list

plugins: fix cmake plugin prefix

View original Github issue

Metadata

Project
craft-parts
Number
#263
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and passing CI. Fixed cmake plugin prefix path formatting and aligned the installation prefix with v1 plugins. Rebased on main.

Suggested action:

No scores available.

Issue body

Properly format the cmake prefix path string, and set the installation prefix to match v1 plugins. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1154

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and passing CI. Fixed cmake plugin prefix path formatting and aligned the installation prefix with v1 plugins. Rebased on main.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the cmake plugin prefix. The change properly formats the prefix path string and aligns the installation prefix with v1 plugins. Claudio Matsuoka amended and rebased the commit on main prior to merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#268 Release 1.12.1 craft-parts merged Merged release 1.12.1, reverting cmake plugin install prefix changes to resolve stable base incompatibility. Approved by one reviewer and passed CI checks prior to merge.
76%
#3037 plugins: introduce v2.CMakePlugin snapcraft merged Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions.
72%
#249 fix: rename plugin to plugin_name craft-parts merged Merged a fix renaming the plugin variable to plugin_name to accurately represent it as a string rather than a Plugin object. The change was approved, passed CI checks, and modified five files.
72%
#184 plugins: cmake craft-parts merged Merged the cmake plugin port to craft-parts following approval from two reviewers and passing CI checks. The maintainer addressed review feedback regarding leftover code prior to integration.
72%
#1645 docs: fix cmake plugin ref in parts explanation craft-parts merged Merged a documentation update correcting a cmake plugin reference in the parts explanation. The PR addressed reviewer feedback, received approval, and passed CI checks following a temporary linter failure caused by an external website outage.
72%
#266 Release 1.12.0 craft-parts merged Merged release 1.12.0 by maintainer cmatsuoka. Updates set and fix the install prefix in the cmake plugin. Approved by one reviewer with no unresolved comments.
71%
#3013 plugins: use v1 import path for all plugins snapcraft merged Merged following reviewer approval and successful CI checks. Updated all plugin import paths to v1 across 25 files, resulting in a net change of +86/-94 lines.
70%