CMake plugin: Support installing via prefix.
Metadata
Current evaluation
Closed unmerged after the change was found to target CMake instead of Autotools; equivalent prefix-install support merged in snapcraft#351 via commit 72dbc3285.
Resolution: closed superseded
Reason: The author closed #346 because the proposed change belonged in the Autotools plugin. Equivalent Autotools support was subsequently merged in #351 at commit 72dbc3285.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Currenty the CMake plugin uses an empty CMAKE_INSTALL_PREFIX and installs into the install directory via utilizing DESTDIR. This PR resolves LP: [#1544630](https://bugs.launchpad.net/snapcraft/+bug/1544630) by adding the ability to install via actually using CMAKE_INSTALL_PREFIX.
Also ups the CMake plugin coverage to 100%.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after the change was found to target CMake instead of Autotools; equivalent prefix-install support merged in snapcraft#351 via commit 72dbc3285. | |
| stealth/space-bunny-alpha | — | closed not a bug | Closed unmerged: changes targeted CMake instead of Autotools. The equivalent Autotools prefix-install support was merged in canonical/snapcraft#351. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The author realized the changes were applied to the wrong plugin and determined CMake did not require them. The pull request was abandoned, though a later comment notes the underlying installation issue persists. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed and abandoned. The author applied the patch to the wrong plugin and determined CMake does not need this change. The original issue remains unresolved. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#351
(confidence 100%)
Merged Autotools prefix-install support replacing the misplaced CMake implementation.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1544630 CMake plugin should support installing via prefix instead of DESTDIR | snapcraft (launchpad) | closed | Prefix-based installation landed for Autotools in merged PR #351; referenced PR #346 was closed unmerged after targeting the wrong plugin. | |
| #1544629 Autotools plugin should support installing via prefix instead of DESTDIR | snapcraft (launchpad) | closed | Prefix-based Autotools installation was merged in canonical/snapcraft#351, resolving Launchpad bug #1544629 in commit 72dbc3285. | |
| #352 Backport to 1.x: Autotools plugin: Support installing via prefix. | snapcraft | merged | Merged into Snapcraft 1.x, adding prefix-based installation to the Autotools plugin as a backport of #351. | |
| #351 Autotools plugin: Support installing via prefix. | snapcraft | merged | Merged PR #351 by kyrofa adds an Autotools plugin config option to install via prefix instead of DESTDIR, fixing LP bug #1544629 (commit 72dbc3285). Reviewed and approved by sergiusens and come-maiz. | |
| #536 Always set prefix in the autotools plugin | snapcraft | closed | Closed unmerged: hard-coding an autotools prefix would break existing builders; maintainers suggested a separate install-via option instead. | |
| #267 plugins: drop cmake install prefix argument | craft-parts | merged | Merged in canonical/craft-parts#267, dropping the CMake plugin's default CMAKE_INSTALL_PREFIX to preserve core22 usr/local/bin behavior while allowing an explicit prefix. | |
| #263 plugins: fix cmake plugin prefix | craft-parts | merged | Merged #263 as 71b71990 (implementation 78036efe), fixing CMake prefix-path formatting and matching installation prefix behavior to v1 plugins (CRAFT-1154). |