← Back to issue list

migration: support Permissions when migrating files

View original Github issue

Metadata

Project
craft-parts
Number
#301
Type
pull request
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; superseded by canonical/craft-parts#304, which merged the same permissions-forwarding for stage-to-prime migration in commit 8e87ebf2.

Resolution: closed superseded

Reason: PR #301 was closed in favour of canonical/craft-parts#304 (same title, 'migration: support permissions when migrating files'), which was merged as commit 8e87ebf2; the collision-handling follow-up landed separately in #305 (commit b93c135d).

Evaluated by: mr-cal-bot

No scores available.

Issue body

The migration of part files from 'stage' to 'prime' now takes into account the part's 'permissions' definition. This means forwarding the permissions lists all the way down to 'link_or_copy()'. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This does *not* handle conflicts/collisions between parts; that will be handled in the next PR on this topic

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; superseded by canonical/craft-parts#304, which merged the same permissions-forwarding for stage-to-prime migration in commit 8e87ebf2.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of canonical/craft-parts#304, which merged permission forwarding for stage-to-prime migration in commit 8e87ebf2; collision handling remained a separate follow-up.
qwen/qwen3.6-35b-a3b — — Closed to implement permission forwarding during stage-to-prime file migration. Conflict handling between parts was deferred to a follow-up PR.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable permission preservation during stage-to-prime file migration. Permissions are now passed to link_or_copy(). Handling of part conflicts was deferred to a follow-up pull request.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#304 (confidence 95%)

    Merged PR carrying the same change, landing as commit 8e87ebf2 'migration: support permissions when migrating files'.

  • Related To: canonical/craft-parts#305 (confidence 80%)

    Merged follow-up (commit b93c135d) adding permission-aware collision detection, explicitly deferred out of #301.

  • Related To: canonical/craft-parts#296 (confidence 65%)

    Earlier merged PR introducing the Permissions model this work builds on.

Related issues

Issue Project State Summary Similarity
#304 migration: support Permissions when migrating files craft-parts merged PR #304 was merged, preserving part permissions when migrating files from stage to prime and forwarding them to link_or_copy(); commit 8e87ebf2.
85%