← Back to issue list

plugins: add base class for java-related plugins

View original Github issue

Metadata

Project
craft-parts
Number
#339
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged #339 as b628bddf, adding a shared JavaPlugin base class; Ant now derives from it, preparing common support for the Maven plugin.

Resolution: closed resolved

Reason: The approved PR was merged as commit b628bddf. It introduced JavaPlugin and refactored AntPlugin to inherit the shared Java-project behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add a common base class for plugins that build Java projects. This is currently used by the Ant plugin, but it should be also used by the upcoming Maven plugin. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #339 as b628bddf, adding a shared JavaPlugin base class; Ant now derives from it, preparing common support for the Maven plugin.
stealth/space-bunny-alpha — closed resolved Merged PR #339 (b628bddf), adding a shared base class for Java plugins, used by Ant and prepared for the upcoming Maven plugin.
qwen/qwen3.6-35b-a3b — — Merged changes adding a shared base class for Java-related plugins to support the Ant plugin and upcoming Maven build. Approved by one reviewer, passed CI, and modified three files with 44 additions and 35 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged a change introducing a base class for Java-related plugins, enabling shared build logic for the Ant plugin and the upcoming Maven plugin.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#340 (confidence 98%)

    The follow-up Maven plugin implementation uses the shared JavaPlugin base.

Related issues

Issue Project State Summary Similarity
#332 plugins: add ant plugin craft-parts merged Merged PR #332 (commit 646578d1), adding the Ant plugin to build Java projects and install a bin/java symlink plus generated JAR files.
78%
#2370 ant plugin: add support for bases snapcraft merged Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776.
73%