ant plugin: add support for bases
Metadata
Current evaluation
Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776.
Resolution: closed resolved
Reason: The PR itself was merged into master as commit eab7fcf15 ("ant plugin: add support for bases (#2370)"), the change appearing in the history of snapcraft/plugins/ant.py. It implements the base-aware Ant/Maven plugin requested in Launchpad bug #1794776.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Update the Maven plugin to be base-aware, only supporting core16 and
core18.
LP: #1794776
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2370 as eab7fcf15, making the Ant plugin base-aware and supporting only core16 and core18. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2370 via commit eab7fcf15, making the Ant plugin base-aware and supporting only core16 and core18; addresses Launchpad #1794776. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as eab7fcf15 in snapcore/snapcraft#2370: the Ant plugin became base-aware, with support limited to core16 and core18. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and CI. Adds base support to the ant plugin, restricting it to core16 and core18. Modifies 14 files with 83.54% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added base support to the Maven plugin, restricting compatibility to core16 and core18. Resolved Launchpad bug #1794776. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2364
(confidence 88%)
Sibling PR merging the equivalent base-awareness change for the maven plugin (commit b4aebc678, LP #1794793).
-
Related To:
snapcraft#2372
(confidence 88%)
Companion PR for the gradle plugin base support (commit 58bbbda02), merged in the same series.
-
Related To:
snapcraft#2346
(confidence 80%)
Companion PR adding core16/core18 support to the ruby plugin (commit bdb2b85e3).
-
Caused By:
snapcraft#2453
(confidence 55%)
Later fix (41facca0a) correcting JRE defaults/path handling for ant and maven plugins under core18, stemming from the bases work.
-
Related To:
snapcraft#2596
(confidence 50%)
Follow-up commit 8391f290d making the ant build file location configurable, building on this base-aware ant plugin.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2364 maven plugin: add support for bases | snapcraft | merged | PR snapcraft#2364 merged as commit b4aebc678, making the Maven plugin base-aware with support for core16 and core18, resolving Launchpad bug #1794793 (18 files, +778/-345). | |
| #1794776 Update the ant plugin to be base aware | snapcraft (launchpad) | closed | Ant plugin was made base-aware by merged PR snapcore/snapcraft#2370 (commit eab7fcf15), adding core16 and core18 support. | |
| #2373 rust plugin: add support for bases | snapcraft | merged | Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681. | |
| #2362 python plugin: add support for bases | snapcraft | merged | Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread. | |
| #2372 gradle plugin: add support for bases | snapcraft | merged | Merged in snapcraft#2372 (58bbbda02), making the Gradle plugin base-aware with support limited to core16 and core18. | |
| #2357 scons plugin: add support for bases | snapcraft | merged | Merged #2357, making the Scons plugin base-aware for core16/core18; landed as commit 883c308c9 and resolved LP #1794801. | |
| #2358 dotnet plugin: add support for bases | snapcraft | merged | Merged PR #2358 as commit 58a06ef40, making the .NET plugin base-aware and limiting support to core16. | |
| #2346 ruby plugin: add support for base | snapcraft | merged | Ruby plugin base support was merged into master via #2346 (commit bdb2b85e3), adding core16/core18 support and resolving LP #1794800. | |
| #2363 {make,cmake,autotools} plugin: add support for bases | snapcraft | merged | Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93. | |
| #2368 {kbuild,kernel} plugin: add support for bases | snapcraft | merged | Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791. |