← Back to issue list

linters: set disallow_untyped_defs in mypy

View original Github issue

Metadata

Project
craft-parts
Number
#350
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI. Enables mypy disallow_untyped_defs, enforcing type annotations across 55 files in craft_parts. Author updated tests and addressed reviewer feedback prior to merge.

Suggested action:

No scores available.

Issue body

This forces type annotations for functions in craft_parts/. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI. Enables mypy disallow_untyped_defs, enforcing type annotations across 55 files in craft_parts. Author updated tests and addressed reviewer feedback prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged. Enables mypy's disallow_untyped_defs setting, enforcing strict type annotations for all functions in craft_parts. Test code was updated to align with the new typing requirements following reviewer feedback.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#90 many: address new linter warnings (CRAFT-364) craft-parts merged Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines).
76%
#6 tools: Configure mypy starbase merged Configuring mypy was approved by one reviewer and successfully merged. The update modified two files, adding 30 lines and removing 1, to establish type checking in the project tools.
71%
#35 Make type checkers aware of type annotations craft-cli merged Merged to add a py.typed file to craft-cli, enabling static type checkers like mypy to recognize its type annotations. Approved and passed CI.
71%