plugins: implement strict/offline plugins
Metadata
Current evaluation
Merged strict/offline plugin support in PR #361 via commit 1a9a48bd, separating dependency pulls from build execution and adding tests.
Resolution: closed resolved
Reason: PR #361 was approved and merged as commit 1a9a48bd. It added strict-mode plugin support and tests so dependencies are acquired during pull steps and builds can run offline.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The first commit has @cmatsuoka 's original code with some minor linting by me. The second commit has the tests I added.
One thing we should maybe discuss is this `strict`/`offline` "duality". Really what a "strict" plugin currently means is that it does offline builds, but is that definition something that we envision changing in the future? Should we use "strict" throughout the codebase?
(CRAFT-1587)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged strict/offline plugin support in PR #361 via commit 1a9a48bd, separating dependency pulls from build execution and adding tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged strict/offline plugin support in craft-parts #361 via commit 1a9a48bd, separating pull/build responsibilities and adding tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged strict/offline plugin support in craft-parts PR #361, commit 1a9a48bd, with dedicated pull/build steps and tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after implementing strict/offline plugins with tests and linting. Reviewers approved the changes following a discussion clarifying that strict mode enforces dedicated pull and build steps. The updated version passed CI and was merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged strict/offline plugin implementation ensuring proper pull-then-build step separation. Incorporates original code, tests, linting, and updates from maintainer discussions. Resolves CRAFT-1587. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #762 node plugin: run build in pull phase to download dependencies. | snapcraft | merged | Merged PR #762 as commit 0b3283081, moving npm dependency downloads to pull and enabling offline builds with --cache-min=Infinity. |