node plugin: run build in pull phase to download dependencies.
Metadata
Current evaluation
Merged. Relocates npm dependency installation to the pull phase and adds --cache-min=Infinity to enable offline builds. Replaces -g with --global. Verified offline functionality and approved.
Suggested action: —
No scores available.
Issue body
This runs the build in the pull phase to download all needed dependencies.
There is no way to 'npm install --download-only'.
Additionally, we add the --cache-min=Infinity which is required.
Without it, the run in the build phase will try to reach the npm registry.
Lastly, instead of '-g', use the more self-documenting long form '--global'.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Relocates npm dependency installation to the pull phase and adds --cache-min=Infinity to enable offline builds. Replaces -g with --global. Verified offline functionality and approved. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. The node plugin now executes npm install during the pull phase with --cache-min=Infinity to fetch dependencies upfront, ensuring offline builds. Code was adjusted per reviewer feedback before approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Moves npm dependency installation to the pull phase to enable offline builds, adds --cache-min=Infinity to prevent registry access, and updates flags. Approved by maintainer and integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1633298 nodejs plugin never runs install during pull | snapcraft (launchpad) | closed | Fixed the nodejs plugin to run npm install during the pull phase by correcting the builddir path check, resolving downstream build failures. |