← Back to issue list

parts: unmarshal plugin properties

View original Github issue

Metadata

Project
craft-parts
Number
#40
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged following two reviewer approvals and passing CI. The change implements validation and unmarshaling logic for plugin properties, assigning them to their corresponding parts across six modified files.

Suggested action: —

No scores available.

Issue body

Plugin properties are specified along part properties and prefixed by the plugin name. Validate and unmarshal properties and assign them to the corresponding part. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged following two reviewer approvals and passing CI. The change implements validation and unmarshaling logic for plugin properties, assigning them to their corresponding parts across six modified files.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes that validate, unmarshal, and assign plugin properties prefixed by the plugin name to their corresponding parts.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#775 chore!: restructure plugin models craft-parts merged Merged restructuring of plugin models. Removed PluginModel, consolidated PluginPropertiesModel and PluginProperties, and unified the unmarshal method across all plugins. Approved by two reviewers with passing CI, modifying 29 files.
73%
#1507 many: simplify plugin loading snapcraft merged Merged an architectural refactor that simplifies plugin loading by shifting initialization from PluginHandler to PartsConfig. Approved by one reviewer across 13 files, the change decouples components and enables future grammar processing extraction.
72%
#277 parts: add part validator craft-parts merged Merged adds a centralized part validation helper that validates data against part and plugin models, replacing per-tool logic. Approved, passed CI, and resolves issue #176.
72%