← Back to issue list

chore!: restructure plugin models

View original Github issue

Metadata

Project
craft-parts
Number
#775
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged restructuring of plugin models. Removed PluginModel, consolidated PluginPropertiesModel and PluginProperties, and unified the unmarshal method across all plugins. Approved by two reviewers with passing CI, modifying 29 files.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This does several related things: 1. Removes the vestigial `PluginModel` from `craft_parts.plugins.base` 2. Combines `PluginPropertiesModel` and `PluginProperties` (which didn't need separation anymore) 3. Makes the `unmarshal` method of `PluginProperties` usable by all plugins (and deletes the unnecessary overrides)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged restructuring of plugin models. Removed PluginModel, consolidated PluginPropertiesModel and PluginProperties, and unified the unmarshal method across all plugins. Approved by two reviewers with passing CI, modifying 29 files.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring that restructured plugin models by removing the obsolete PluginModel, consolidating PluginPropertiesModel and PluginProperties, and unifying the unmarshal method across all plugins.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#40 parts: unmarshal plugin properties craft-parts merged Merged following two reviewer approvals and passing CI. The change implements validation and unmarshaling logic for plugin properties, assigning them to their corresponding parts across six modified files.
73%
#667 chore!(models): remove BuildInfo and BuildPlanner craft-application merged Merged a breaking change removing the BuildInfo and BuildPlanner models across nine files, deleting 430 lines and adding 36. Approved by two reviewers and passed CI checks.
72%