← Back to issue list

chore!: restructure plugin models

View original Github issue

Metadata

Project
craft-parts
Number
#775
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #775 as commit 029f1ad6, removing PluginModel, consolidating plugin property models, and making unmarshal reusable across plugins.

Resolution: closed resolved

Reason: PR #775 was merged into main by commit 029f1ad6. It removed the vestigial PluginModel, combined PluginPropertiesModel with PluginProperties, and generalized unmarshalling across plugins.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This does several related things: 1. Removes the vestigial `PluginModel` from `craft_parts.plugins.base` 2. Combines `PluginPropertiesModel` and `PluginProperties` (which didn't need separation anymore) 3. Makes the `unmarshal` method of `PluginProperties` usable by all plugins (and deletes the unnecessary overrides)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #775 as commit 029f1ad6, removing PluginModel, consolidating plugin property models, and making unmarshal reusable across plugins.
stealth/space-bunny-alpha — closed resolved Merged in #775 as commit 029f1ad6, removing PluginModel, consolidating plugin property models, and making unmarshal reusable across plugins.
stealth/space-bunny-alpha — closed resolved Merged in #775 as commit 029f1ad6, removing PluginModel, consolidating plugin property models, and making unmarshal reusable across all plugins.
qwen/qwen3.6-35b-a3b — — Merged restructuring of plugin models. Removed PluginModel, consolidated PluginPropertiesModel and PluginProperties, and unified the unmarshal method across all plugins. Approved by two reviewers with passing CI, modifying 29 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactoring that restructured plugin models by removing the obsolete PluginModel, consolidating PluginPropertiesModel and PluginProperties, and unifying the unmarshal method across all plugins.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#787 chore: simplify extract_plugin_properties craft-parts merged Merged PR #787 in commit f689ed84, simplifying extract_plugin_properties to address Ruff 0.5's for-loop lint complaint.
71%